Enhanced Session Recording Improvements #3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russjones
force-pushed
the
rjones/enhanced-fixes
branch
from
57dd767
to
01f4e37
Compare
webvictim
approved these changes
Jan 15, 2020
fspmarshall
reviewed
Jan 15, 2020
russjones
force-pushed
the
rjones/enhanced-fixes
branch
2 times, most recently
from
38d87bd
to
39304f9
Compare
fspmarshall
approved these changes
Jan 16, 2020
Drop everything after "-" when looking up the kernel version to make it easier for the semver library to compare kernel versions.
Instead of using the "name_to_handle_at" in glibc, call unix.NameToHandleAt (which issues that syscall directly). This allows for cgroup resolution on systems with older version of glibc (like the one that ships with CentOS 6). See the following links for more details: http://man7.org/linux/man-pages/man2/open_by_handle_at.2.html https://godoc.org/golang.org/x/sys/unix#NameToHandleAt
PID and parent PID were swapped in command events.
If the page size for an enhanced event is 0, then don't attempt to load that BPF program. This is helpful for BPF programs that generate massive amounts of events (like disk events).
russjones
force-pushed
the
rjones/enhanced-fixes
branch
from
39304f9
to
d80f666
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolled a variety of fixes to enhanced session recording improvements into this PR.