fix cert reissue compatibility #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
requested review from
klizhentas,
russjones and
webvictim
as code owners
fspmarshall
force-pushed
the
fspmarshall/fix-uuid-cert-compat
branch
from
6782b35
to
2b9bd3d
Compare
russjones
reviewed
Mar 17, 2020
|
Original PR: #3377 |
russjones
approved these changes
Mar 17, 2020
webvictim
approved these changes
Mar 17, 2020
klizhentas
approved these changes
Mar 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where certificate checks were causing nodes to go into an infinite restart loop when dealing with an older auth server.
Previously, nodes were checking for the presence of Host UUID in their cert principals, and triggering re-issue if it did not exist. This logic caused an infinite loop since older auth servers don't add Host UUID automatically.
After this patch nodes will explicitly add Host UUID to their own principals list, allowing them to ensure that their certificates contain Host UUID even if the Auth Server is outdated.