Show clear error when session can't be exported #35880
Conversation
…f sending back chunks of the screen, its sends the full screen every time, and this is my running hypothesis for the current sticking point: a "Maximum call stack size exceeded" from the tdp client in the react app
…all stack size exceeded" bug
…g produced by IronRDP
… for client.write_frame though this requires more research.
Requires some modifications to IronRDP, see the corresponding commit hash for IronRDP in lib/srv/desktop/rdp/rdpclient/Cargo.toml. Started getting call stack overflows when manual testing again, but I'm going to ignore those for now and focus on the version of this architecture that passes the remoteFX encoded messages over TDP.
Building the wasm module still needs to be done manually, this was just to get to a point where tools are configured and it can be successfully called in both dev and prod modes. Required that I comment out "default-src 'self'" in the CSP, this will need to be figured out later. We're also using a package called vite-plugin-wasm-pack whereas ironrdp uses vite-plugin-wasm. I'm not sure why, I'm going to look into this and swap out to vite-plugin-wasm if possible.
…asm script to the teleport package.json. vite-plugin-wasm-pack looks relatively unmaintained in comparison to vite-plugin-wasm-pack. build-wasm script is needed to build the wasm binary before calling vite [build]
Untested as of yet and it isn't pretty, but this more or less imitates the RPC approach we have for directory sharing.
… SHOULD DO SOMETHING ELSE
with a particular commit of IronRDP. Unfortunately this commit is now well out of date, and IronRDP had some bugs that were preventing RemoteFX frames from being sent back.
…, etc.) rather than relying on whatever is re-exported from the ironrdp sub-crate itself
…n wasm and js, adding some comments
renaming them to be precise.
Updates IronRDP to latest with the changes necessary to keep up with the changes in Devolutions/IronRDP#328. We select the `"rustls"` feature explicitly now, this is in line with our implicit choice of it as [the default](https://github.com/Devolutions/IronRDP/pull/325/files#diff-1f64036f3e460819b2b1e954803b7f266feca0e2787ca0614ae1253323944f59L19) before these latest changes. Also creates a custom debug for `ScardBackend` so as to not leak `key_der` in the logs.
github-actions
bot
added
size/sm
tsh
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
|
This works. We could make it even better by marking the session as errored when we see the RemoteFX frame, but continuing to stream through until we hit the session end event. The session end event has enough information to construct the URL to playback the session, so we could link the user directly to it.. |
probakowski
added
the
no-changelog
|
@zmb3 I've added url to the error message (I don't know if it's quite correct, can we always assume https?) |
tool/tsh/common/recording_export.go
Outdated
| webProxyAddr, | ||
| evt.ClusterName, | ||
| evt.SessionID, | ||
| lastEmitted) |
There was a problem hiding this comment.
Instead of using lastEmitted, you could compute the duration by looking at the StartTime and EndTime fields of the WindowsDesktopSessionEnd event.
This would be more correct in cases where there was idle time prior to the session end event.
There was a problem hiding this comment.
That's better, I've changed it, thanks!
IIRC the proxy always redirects http connection attempts to https. Could be wrong, but either way seems safe to assume the vast majority of users will want https. |
As
tshdoesn't understand IronRDP frames yet it outputs completely black video when exporting new session recordings.This changes returns error message in that case pointing user to web UI.