Fixed regressions in "tsh login <clusterName>". #3639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russjones
requested review from
awly,
fspmarshall,
klizhentas and
webvictim
as code owners
fspmarshall
approved these changes
Apr 29, 2020
awly
approved these changes
Apr 29, 2020
Fixed regressions in how the cluster name was set in the profile when doing "tsh login <clusterName>". The following examples illustrate expected behavior. Suppose root cluster is example.com and the leaf cluster is leaf.example.com. * "tsh login" will update profile to example.com. * "tsh login example.com" will update profile to example.com. * "tsh login leaf.example.com" will update profile to leaf.example.com. * "tsh login invalid.example.com" will return an error. Note: The profile is only updated when a identity flag is NOT provided. This means the following command will NOT update the profile: tsh --proxy=example.com login --out=certs.pem leaf.example.com
russjones
force-pushed
the
rjones/double-login
branch
from
890e3b9
to
f45dbc0
Compare
webvictim
approved these changes
Apr 29, 2020
This was referenced May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed regressions in how the cluster name was set in the profile when doing
tsh login <clusterName>. The following examples illustrate expected behavior.Suppose root cluster is
example.comand the leaf cluster isleaf.example.com.tsh loginwill update profile toexample.com.tsh login example.comwill update profile toexample.com.tsh login leaf.example.comwill update profile toleaf.example.com.tsh login invalid.example.comwill return an error.Note: The profile will not be updated if an identity flag is provided. This means the following command will NOT update the profile:
Related Issues
Fixes #3550
Fixes #3102