Self-test kube impersonation permissions at startup #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
awly
commented
Jun 10, 2020
added 4 commits
June 10, 2020 15:06
To help operators diagnose mis-configured kubeconfig or k8s RBAC roles, make proxy verify that impersonation is allowed. If not, fail at startup. Note: this requires the proxy to have permissions to create SelfSubjectAccessReviews. Fixes #3649
The new permission is there to allow the proxy to self-test impersonation powers at startup and surface RBAC problems early.
awly
force-pushed
the
andrew/k8s-perms-selftest
branch
from
37fda7e
to
18d3893
Compare
russjones
approved these changes
Jun 11, 2020
awly
pushed a commit
that referenced
this pull request
Oct 14, 2020
Prior to #3811, if users wanted to run a root proxy without k8s clusters but leaf proxies with k8s, they had to put a dummy `kubeconfig_file` on the root proxy. The permissions self-test added in #3812 didn't take that into account. So, users who keep the old workaround and upgrade to 4.4 will see their proxies fail to start. To recover, they have to realize that `kubeconfig_file` can be removed.
awly
pushed a commit
that referenced
this pull request
Oct 14, 2020
Prior to #3811, if users wanted to run a root proxy without k8s clusters but leaf proxies with k8s, they had to put a dummy `kubeconfig_file` on the root proxy. The permissions self-test added in #3812 didn't take that into account. So, users who keep the old workaround and upgrade to 4.4 will see their proxies fail to start. To recover, they have to realize that `kubeconfig_file` can be removed.
awly
pushed a commit
that referenced
this pull request
Oct 14, 2020
Prior to #3811, if users wanted to run a root proxy without k8s clusters but leaf proxies with k8s, they had to put a dummy `kubeconfig_file` on the root proxy. The permissions self-test added in #3812 didn't take that into account. So, users who keep the old workaround and upgrade to 4.4 will see their proxies fail to start. To recover, they have to realize that `kubeconfig_file` can be removed.
awly
pushed a commit
that referenced
this pull request
Oct 14, 2020
Prior to #3811, if users wanted to run a root proxy without k8s clusters but leaf proxies with k8s, they had to put a dummy `kubeconfig_file` on the root proxy. The permissions self-test added in #3812 didn't take that into account. So, users who keep the old workaround and upgrade to 4.4 will see their proxies fail to start. To recover, they have to realize that `kubeconfig_file` can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help operators diagnose mis-configured kubeconfig or k8s RBAC roles,
make proxy verify that impersonation is allowed. If not, fail at
startup.
Note: this requires the proxy to have permissions to create
SelfSubjectAccessReviews.Fixes #3649