tf-provider: fix bool option on gitlab token #40283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
strideynet
reviewed
Apr 8, 2024
hugoShaka
force-pushed
the
hugo/vendor-terraform-provider
branch
from
36a28a0 to
b1e30bc
Compare
hugoShaka
force-pushed
the
hugo/fix-gitlab-token
branch
from
142085b to
edc33fb
Compare
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
strideynet
approved these changes
May 7, 2024
| resource.TestCheckResourceAttr(name, "metadata.name", "gitlab-test-terraform"), | ||
| resource.TestCheckResourceAttr(name, "spec.roles.0", "Bot"), | ||
| resource.TestCheckResourceAttr(name, "spec.join_method", "gitlab"), | ||
| resource.TestCheckNoResourceAttr(name, "spec.gitlab.allow.0.environment_protected"), |
There was a problem hiding this comment.
Just to make sure that this is working properly for when it is set, could we add:
ref_protected = true
to the fixture, and
resource.TestCheckResourceAttr(name, "spec.gitlab.allow.0.ref_protected", "true")to the test checks.
marcoandredinis
approved these changes
May 8, 2024
hugoShaka
force-pushed
the
hugo/fix-gitlab-token
branch
from
f7ea8ef to
c382b14
Compare
|
@hugoShaka See the table below for backport results.
|
hugoShaka
added a commit
that referenced
this pull request
May 10, 2024
* Add BoolOptionNullable type for token * Address noah's comment * add more tests to check if we can set then unset the value * lint * lint pt.2 * lint pt.3
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 13, 2024
* tf-provider: fix bool option on gitlab token (#40283) * Add BoolOptionNullable type for token * Address noah's comment * add more tests to check if we can set then unset the value * lint * lint pt.2 * lint pt.3 * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the broken bool options on the provisioning token in allow rules.
This cannot be made on every resource yet because this is a breaking change for some roles.
This is a temporary fix, the proper way to fix it is doing a v16 breaking change. We need to do this hack today to unblock a large customer.
changelog: fix a bug in the Terraform provider causing the Provision Token boolean options to default to false instead of empty.