Fix Helm chart public_addr for proxy when using Ingress #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webvictim
commented
Jul 23, 2020
| public_addr: {{ .Values.config.public_address }}:{{ .Values.ports.proxyweb.containerPort }} | ||
| {{- if .Values.ingress.enabled }} | ||
| {{- if .Values.ingress.tls }} | ||
| public_addr: {{ .Values.config.public_address }}:443 |
There was a problem hiding this comment.
Assumptions:
- when TLS is configured on the
Ingressit'll be using port 443 - when TLS is not configured on the
Ingressit'll be using port 80
When not using an Ingress, we change to using the host-side proxyweb port under the service definition rather than the container-side port.
benarent
reviewed
Jul 23, 2020
awly
approved these changes
Jul 24, 2020
|
@benarent Could I have an approval stamp please? I think you're code owner on |
benarent
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an
Ingressto front your Teleport cluster in Kubernetes, access will be via port 443 (HTTPS) or 80 (HTTP - not recommended). Unfortunately, the Helm chart makes the assumption that you'll always be on port 3080 and this breakstshlogins at the command line. This fixes that problem by specifically overriding thepublic_addrofproxy_servicewhen using anIngress.I also changed all other
public_addrsettings in the main Helm chart to use the configured service port, rather than thecontainerPort. This means that other traffic will be directed correctly if people change the default ports in their config.I also found a lot of random trailing spaces and blank tabs, so the PR removes all of those that I could find under our Helm charts too.
Fixes #4080