Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StyledCheckbox design #42574

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Update StyledCheckbox design #42574

merged 4 commits into from
Jun 10, 2024

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented Jun 6, 2024

This change will be followed by one that introduces labeled checkboxes and replaces legacy checkboxes with this one.

Screenshot 2024-06-06 at 19 22 37

Screenshot 2024-06-06 at 19 24 53

Screenshot 2024-06-06 at 19 24 35

Screenshot 2024-06-06 at 19 25 07

Figma: https://www.figma.com/design/Gpjs9vjhzUKF1GDbeG9JGE/Application-Design-System?node-id=6924-34152&t=PetyQnTVZuOT6pRJ-0

Contributes to #42573

Copy link

github-actions bot commented Jun 6, 2024

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@bl-nero bl-nero added the no-changelog Indicates that a PR does not require a changelog entry label Jun 7, 2024
@@ -73,6 +73,7 @@ export const Icons = () => (
<IconBox IconCmpt={Icon.ChatBubble} text="ChatBubble" />
<IconBox IconCmpt={Icon.ChatCircleSparkle} text="ChatCircleSparkle" />
<IconBox IconCmpt={Icon.Check} text="Check" />
<IconBox IconCmpt={Icon.CheckThick} text="CheckThick" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bl-nero bl-nero enabled auto-merge June 10, 2024 18:26
@bl-nero bl-nero added this pull request to the merge queue Jun 10, 2024
Merged via the queue into master with commit b212f28 Jun 10, 2024
39 checks passed
@bl-nero bl-nero deleted the bl-nero/checkboxes branch June 10, 2024 18:39
@public-teleport-github-review-bot

@bl-nero See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants