Add status icons to VNet panel, adjust empty state copy & start notification #43090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
added
no-changelog
ravicious
requested review from
avatus
and removed request for
ibeckermayer and
ryanclark
gzdunek
approved these changes
Jun 17, 2024
zmb3
approved these changes
Jun 17, 2024
public-teleport-github-review-bot
bot
removed the request for review
from avatus
|
@ravicious See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some icons so that it's easier to see what state VNet is in. "Just" has been removed from the empty state copy. After clicking "Connect" next to a TCP app, the notification is always shown, even if we failed to copy the address to the clipboard.