Remove lib/shell from lib/client #43119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shell package requires cgo and by importing it in lib/client, which all client tools have in their dependency tree, it prevents them from building without GCO_ENBALED=1. Updates #43112.
rosstimothy
added
backport/branch/v14
no-changelog
github-actions
bot
added
size/sm
tsh
avatus
approved these changes
Jun 17, 2024
marcoandredinis
approved these changes
Jun 17, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@rosstimothy See the table below for backport results.
|
This was referenced Jun 17, 2024
rosstimothy
added a commit
that referenced
this pull request
Jun 17, 2024
The shell package requires cgo and by importing it in lib/client, which all client tools have in their dependency tree, it prevents them from building without GCO_ENBALED=1. Updates #43112.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shell package requires cgo and by importing it in lib/client, which all client tools have in their dependency tree, it prevents them from building without GCO_ENABLED=1.
Updates #43112.