Implement new buttons design #43662
Merged
Implement new buttons design #43662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bl-nero
added
the
no-changelog
ryanclark
approved these changes
Jul 1, 2024
rudream
approved these changes
Jul 4, 2024
|
Note: pushed with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first in a chain.
Due to the complexity of the change, it's closely tied to a follow-up Enterprise PR https://github.com/gravitational/teleport.e/pull/4532.
The scope of this change is to implement the new design and only change the actual UIs in places where it's strictly necessary to keep the build green. Subsequent UI modifications will be addressed in a follow-up OSS PR #43663.
Known issues:
Deviations from the designs:
inputAlignmentthat stems from my discussions with Kenny and was not a formal part of the original design.Figma: https://www.figma.com/design/Gpjs9vjhzUKF1GDbeG9JGE/Application-Design-System?node-id=6642-29063&t=TpbLdA8lOaDrWW0d-0
Contributes to #43175
Manual tests: Reviewed all the stories in our storybook, comparing them side by side with the master copy. Glitches will be addressed in a follow-up PR to keep this one scoped.