k8s: enable SPDY pings on in/outbound connections #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
awly
force-pushed
the
andrew/k8s-spdy-pings
branch
2 times, most recently
from
978b9ab
to
93d9adf
Compare
|
LGTM once the conflicts are fixed. |
awly
force-pushed
the
andrew/k8s-spdy-pings
branch
from
93d9adf
to
c22af69
Compare
added 2 commits
September 29, 2020 11:17
This helps with ELB and similar L5 load balancers that don't respect TCP-level keep-alives. ELB for example kills connections after 60s of no application traffic. With this PR, you can leave a `kubectl exec` session open indefinitely without any activity.
awly
force-pushed
the
andrew/k8s-spdy-pings
branch
from
c22af69
to
92f15ea
Compare
fspmarshall
approved these changes
Sep 29, 2020
webvictim
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with ELB and similar L5 load balancers that don't respect
TCP-level keep-alives. ELB for example kills connections after 60s of no
application traffic.
With this PR, you can leave a
kubectl execsession open indefinitelywithout any activity.
There's an unfortunate number of dependencies that had to be bumped to bring kubernetes/kubernetes#94170 in. I couldn't figure out a smaller subset of upgrades.
I suggest you review only the 2nd commit in this PR, the 1st one is all dependencies.
Fixes #3765