Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SSO button design and fix autofocus #44889

Merged
merged 4 commits into from
Aug 1, 2024
Merged

Update the SSO button design and fix autofocus #44889

merged 4 commits into from
Aug 1, 2024

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented Jul 31, 2024

  • Use correct IDP icons
  • Add Okta to the list of guessed providers
  • Fix broken autofocus for SSO and passwordless methods
  • Update the docs that contained previously incorrect information about the display attribute of the connector resource definition
Screenshot 2024-07-31 at 19 25 03

Figma: https://www.figma.com/design/v6GunK50D2VC7w7I2FBDNf/Management?node-id=4044-8185&m=dev

Deviations from the design:

  • We decided to abandon the "sign in with" prefix, as it may conflict with existing deployments.
  • We decided to revert back to the centered text.

Fixes #44874
Fixes #36883

- Use correct IDP icons
- Add Okta to the list of guessed providers
- Fix broken autofocus for SSO and passwordless methods
- Update the docs that contained previously incorrect information about the display attribute of the connector resource definition
@bl-nero bl-nero added the no-changelog Indicates that a PR does not require a changelog entry label Jul 31, 2024
@github-actions github-actions bot requested a review from gzdunek July 31, 2024 17:28
@github-actions github-actions bot requested a review from kimlisa July 31, 2024 17:28
@github-actions github-actions bot added the ui label Jul 31, 2024
@bl-nero
Copy link
Contributor Author

bl-nero commented Jul 31, 2024

Oops, I've just realized I broke the layout on Connect. Will fix it tomorrow.

web/packages/design/src/ResourceIcon/index.tsx Outdated Show resolved Hide resolved
@bl-nero
Copy link
Contributor Author

bl-nero commented Aug 1, 2024

Cluster connect dialog layout fixed.

Screenshot 2024-08-01 at 12 46 11

@bl-nero bl-nero added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit 1481cb4 Aug 1, 2024
40 checks passed
@bl-nero bl-nero deleted the sso-buttons branch August 1, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the SSO buttons proper branding for SSO provider
3 participants