-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Web] Implement Navigation Search #46800
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
force-pushed
the
yassine/side-nav-search
branch
from
October 4, 2024 08:54
776a56c
to
d53013e
Compare
rudream
force-pushed
the
yassine/side-nav-search
branch
2 times, most recently
from
October 11, 2024 12:54
fa91741
to
49f6b5e
Compare
rudream
added
the
no-changelog
Indicates that a PR does not require a changelog entry
label
Oct 11, 2024
avatus
reviewed
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I ask for JSDoc on exported types and functions, especially explaining their functionality and scope of usage?
web/packages/teleport/src/Navigation/SideNavigation/Section.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Navigation/SideNavigation/CategoryIcon.tsx
Outdated
Show resolved
Hide resolved
web/packages/teleport/src/Navigation/SideNavigation/Navigation.tsx
Outdated
Show resolved
Hide resolved
rudream
force-pushed
the
yassine/side-nav-search
branch
from
October 17, 2024 10:07
bcaa666
to
202b180
Compare
avatus
approved these changes
Oct 17, 2024
flyinghermit
approved these changes
Oct 17, 2024
rudream
force-pushed
the
yassine/side-nav-search
branch
from
October 18, 2024 19:00
202b180
to
1e74080
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Part of https://github.com/gravitational/teleport.e/issues/3998
e
counterpart: https://github.com/gravitational/teleport.e/pull/5049Adds search to the side navigation to make it easier to find pages within the WebUI.
Demo