Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Web] Implement Navigation Search #46800

Merged
merged 1 commit into from
Oct 18, 2024
Merged

[Web] Implement Navigation Search #46800

merged 1 commit into from
Oct 18, 2024

Conversation

rudream
Copy link
Contributor

@rudream rudream commented Sep 20, 2024

Purpose

Part of https://github.com/gravitational/teleport.e/issues/3998

e counterpart: https://github.com/gravitational/teleport.e/pull/5049

Adds search to the side navigation to make it easier to find pages within the WebUI.

Demo

image

@rudream rudream force-pushed the yassine/side-nav-search branch from 776a56c to d53013e Compare October 4, 2024 08:54
@rudream rudream force-pushed the yassine/side-nav-search branch 2 times, most recently from fa91741 to 49f6b5e Compare October 11, 2024 12:54
@rudream rudream marked this pull request as ready for review October 11, 2024 12:55
@rudream rudream added the no-changelog Indicates that a PR does not require a changelog entry label Oct 11, 2024
Copy link
Contributor

@flyinghermit flyinghermit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask for JSDoc on exported types and functions, especially explaining their functionality and scope of usage?

@rudream rudream force-pushed the yassine/side-nav-search branch from bcaa666 to 202b180 Compare October 17, 2024 10:07
@rudream rudream added this pull request to the merge queue Oct 18, 2024
@rudream rudream removed this pull request from the merge queue due to a manual request Oct 18, 2024
@rudream rudream force-pushed the yassine/side-nav-search branch from 202b180 to 1e74080 Compare October 18, 2024 19:00
@rudream rudream enabled auto-merge October 18, 2024 19:01
@rudream rudream added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit 2bc8cb1 Oct 18, 2024
39 checks passed
@rudream rudream deleted the yassine/side-nav-search branch October 18, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants