Return early when rendering unsupported notification type #47419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
added
no-changelog
kimlisa
approved these changes
Oct 9, 2024
public-teleport-github-review-bot
bot
removed request for
ravicious and
kiosion
mvbrock
pushed a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case where it was possible for an unsupported notification to be rendered despite its content being
null, resulting in a javascript error when trying to access its properties. This bug could only occur in the scenario where a user runs enterprise Teleport, receives an enterprise-only notification (such as for access requests), clicks the notification/marks it as read, and then switches to open source Teleport with the same user on the same cluster.