-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert lib/sshutils to use slog #49829
Conversation
aa3bb4b
to
6bdf674
Compare
9641ea7
to
8e5dad6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should some of those context.Background()
be context.TODO()
instead?
} | ||
c.Log = logger.WithFields(log.Fields{ | ||
teleport.ComponentKey: "SCP", | ||
teleport.ComponentFields: log.Fields{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep this in a group? TBH I've never paid attention to this in our use of logrus.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A group might be fitting, though what would the appropriate key be? scp?
In addition to the conversion, the reverstunnel server now has a slog.Logger provided so that it can be passed into the sshutils.Server, is not used otherwise. A similar migration will be performed in the future for the reversetunnel package.
From RFD 154:
I suppose it may be possible to get a context into some of the places, but for others it would likely require a fair bit of refactoring. |
8e5dad6
to
1ed056d
Compare
In addition to the conversion, the reverstunnel server now has a slog.Logger provided so that it can be passed into the sshutils.Server, is not used otherwise. A similar migration will be performed in the future for the reversetunnel package.