Remove stack traces from web API calls.

[lenko-d]

This PR unwraps errors in order to remove stack traces from web API calls.

• Updates: 2269
• Requires 60

Testing done

Verification of the APIs

Verified that the following APIs don't return the stacktraces:

curl -k -H "Content-Type: application/json" -d '{"username": "example", "password":"invalid"}' https://192.168.1.102:32009/proxy/v1/webapi/sessions 
{
    "error": {
        "message": "access denied"
    }
}

curl -k -H "Content-Type: application/json" -d '{"username": "example", "password":"invalid"}' https://192.168.1.102:32009/proxy/v1/webapi/sessions/renew
{
    "error": {
        "message": "missing session cookie"
    }
}

curl -k -H "Content-Type: application/json" -d '{"username": "example", "password":"invalid"}' https://192.168.1.102:32009/proxy/v1/webapi/github/logi/console
{
    "error": {
        "message": "missing RedirectURL"
    }
}

curl -k -H "Content-Type: application/json" -d '{"username": "example", "password":"invalid"}' https://192.168.1.102:32009/proxy/v1/webapi/u2f/sessions
{
    "error": {
        "message": "bad auth credentials"
    }
}

curl -k -H "Content-Type: application/json" -d '{"username": "example", "password":"invalid"}' https://192.168.1.102:32009/portalapi/v1/sites/sites/domin/users/username/reset
{
    "error": {
        "message": "method not found"
    }
}

[r0mant]

In all places where you do unwrap now, I would consider logging the full error with the stack trace so this information is available for debugging in the logs.

[lenko-d]

@r0mant, I think that I'm not going to use the Unwrap approach at all. The problem is that Unwrap changes the structure of the response considerably. Before Unwrap:

{
    "error": {
        "message": "method not found"
    },
    "traces": [.......]
}

After Unwrap:

{
    "message": "method not found"
}

The change above will most likely require changes for the clients of the API. This doesn't sound good to me.

[r0mant]

@lenko-d Yeah, we definitely shouldn't change the response structure, you can just return the same structure but without traces included.

[knisbet]

Looks fine to me once Dima's nitpick is addressed.

[a-palchikov]

lgtm