-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Revert "fix: Take TTL into account when renewing sessions (#49732)" #51592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec870e1.
marcoandredinis
approved these changes
Jan 29, 2025
gzdunek
approved these changes
Jan 29, 2025
kimlisa
approved these changes
Jan 29, 2025
Thanks, everyone. |
@codingllama See the table below for backport results.
|
codingllama
added a commit
that referenced
this pull request
Jan 29, 2025
codingllama
added a commit
that referenced
this pull request
Jan 29, 2025
carloscastrojumo
pushed a commit
to carloscastrojumo/teleport
that referenced
this pull request
Feb 19, 2025
…nal#49732)" (gravitational#51592) This reverts commit ec870e1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original fix was found to cause renewal failures, likely due to throttled timers on inactive browser tabs.
#49629
Changelog: Fixed occasional Web UI session renewal issues (reverts "Avoid tight renewals for sessions with short TTL")