-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add google_service_account inline field option for Google Workspace/GSuite OIDC #5563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenGravy
requested review from
klizhentas,
r0mant and
russjones
as code owners
February 12, 2021 21:51
stevenGravy
changed the title
Add google_service_account inline field option for Google Workspace OIDC
Add google_service_account inline field option for Google Workspace/GSuite OIDC
Feb 12, 2021
webvictim
reviewed
Feb 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few suggestions
Co-authored-by: Gus Luxton <gus@gravitational.com>
Co-authored-by: Gus Luxton <gus@gravitational.com>
Co-authored-by: Gus Luxton <gus@gravitational.com>
Co-authored-by: Gus Luxton <gus@gravitational.com>
Co-authored-by: Gus Luxton <gus@gravitational.com>
…onal/teleport into stevenGravy/sso/gsuite
…hen using google service account uri or inline.
…onal/teleport into stevenGravy/sso/gsuite
awly
reviewed
Feb 16, 2021
Co-authored-by: Andrew Lytvynov <andrew@goteleport.com>
Co-authored-by: Andrew Lytvynov <andrew@goteleport.com>
Co-authored-by: Andrew Lytvynov <andrew@goteleport.com>
awly
approved these changes
Feb 17, 2021
webvictim
reviewed
Feb 17, 2021
webvictim
approved these changes
Feb 17, 2021
Co-authored-by: Gus Luxton <gus@gravitational.com>
Co-authored-by: Gus Luxton <gus@gravitational.com>
@russjones Could you please review and then approve this PR if it looks OK? |
Ping @russjones |
russjones
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #5523
google_service_account
, that allows for populating the JSON google service account inline. Cloud users wouldn't be able to set a file path for the json contents currently ingoogle_service_account_uri
.google_service_account
orgoogle_service_account_uri
is allowedgoogle_service_account
when not retrieving with secrets.google_service_account_uri
insteadEx: