Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support encrypted SAML assertions #5598

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Support encrypted SAML assertions #5598

merged 1 commit into from
Mar 11, 2021

Conversation

xacrimon
Copy link
Contributor

@xacrimon xacrimon commented Feb 17, 2021 •
edited
Loading

This PR adds support for encrypted SAML assertions.
There is now an option for configuring an additional x509 keypair in the connector resource which will be used for encryption.

@xacrimon
Copy link
Contributor Author

xacrimon commented Feb 17, 2021 •
edited
Loading

@russjones Please select two appropriate reviewers.

@xacrimon xacrimon force-pushed the joel/encrypted-saml branch from 9ea909d to c14c120 Compare February 17, 2021 06:53
@xacrimon xacrimon marked this pull request as draft February 17, 2021 06:54
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch from aab5ed8 to d050fb0 Compare February 17, 2021 10:08
@xacrimon xacrimon marked this pull request as ready for review February 17, 2021 10:37
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch from 7be3cf0 to 3b05182 Compare February 17, 2021 10:38
@russjones russjones requested a review from awly February 18, 2021 01:42
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch 3 times, most recently from 7595c16 to 851e43e Compare February 18, 2021 17:11
@xacrimon xacrimon self-assigned this Feb 18, 2021
@xacrimon
Copy link
Contributor Author

xacrimon commented Feb 19, 2021 •
edited
Loading

Added a test, PR should be ready to go for review.

@xacrimon xacrimon force-pushed the joel/encrypted-saml branch from 69bc965 to 90356d4 Compare February 19, 2021 09:28
a-palchikov
a-palchikov reviewed Feb 19, 2021
View reviewed changes
lib/auth/saml_test.go Outdated Show resolved Hide resolved
lib/auth/saml.go Outdated Show resolved Hide resolved
lib/auth/saml.go Outdated Show resolved Hide resolved
@xacrimon xacrimon requested a review from a-palchikov February 19, 2021 14:23
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch 2 times, most recently from 93cae00 to 31c2536 Compare February 19, 2021 14:41
@xacrimon
Copy link
Contributor Author

Fixes #4220

@xacrimon xacrimon force-pushed the joel/encrypted-saml branch 2 times, most recently from 758c970 to 0fe9841 Compare February 19, 2021 18:37
@russjones russjones added this to the 6.0.1 "Ides of March" milestone Feb 20, 2021
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch from 0fe9841 to 005765e Compare February 21, 2021 12:41
a-palchikov
a-palchikov approved these changes Feb 22, 2021
View reviewed changes
api/types/saml.go Outdated Show resolved Hide resolved
lib/auth/saml.go Outdated Show resolved Hide resolved
lib/auth/saml_test.go Show resolved Hide resolved
@xacrimon xacrimon requested a review from a-palchikov February 22, 2021 11:27
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch from f16946c to 1a0cbec Compare February 22, 2021 11:28
@xacrimon xacrimon added the c-q7j Internal Customer Reference label Feb 22, 2021
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch from 8ca804d to 29da009 Compare February 22, 2021 15:00
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch 3 times, most recently from 719a039 to f9382d1 Compare February 26, 2021 16:30
@xacrimon xacrimon requested a review from awly February 26, 2021 18:36
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch 2 times, most recently from acd33b6 to 43c25a9 Compare February 26, 2021 18:40
awly
awly approved these changes Feb 26, 2021
View reviewed changes
lib/auth/saml.go Outdated Show resolved Hide resolved
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch 7 times, most recently from e8f1308 to de1749f Compare March 5, 2021 17:04
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch 3 times, most recently from 0eb12a0 to ed13e66 Compare March 9, 2021 18:38
@russjones
Copy link
Contributor

@a-palchikov A lot of changes have been made, do you mind re-reviewing?

@xacrimon xacrimon requested a review from russjones March 10, 2021 20:01
@xacrimon xacrimon enabled auto-merge (rebase) March 11, 2021 20:28
russjones
russjones approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot.

lib/services/saml.go Show resolved Hide resolved
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch 2 times, most recently from 2509da5 to 8338b1d Compare March 11, 2021 23:04
@xacrimon xacrimon mentioned this pull request Mar 11, 2021
Merged
@xacrimon xacrimon force-pushed the joel/encrypted-saml branch from 8338b1d to 40ccb77 Compare March 11, 2021 23:17
@xacrimon xacrimon merged commit 0d1a53b into master Mar 11, 2021
@xacrimon xacrimon deleted the joel/encrypted-saml branch March 11, 2021 23:29
@klizhentas klizhentas mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awly awly awly approved these changes

@russjones russjones russjones approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas

@r0mant r0mant Awaiting requested review from r0mant

@a-palchikov a-palchikov Awaiting requested review from a-palchikov

Assignees

@xacrimon xacrimon

Labels
c-q7j Internal Customer Reference
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@xacrimon @russjones @a-palchikov @awly