kube: add kube_public_addr config field to proxy_service #5611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klizhentas
approved these changes
Feb 18, 2021
a-palchikov
approved these changes
Feb 18, 2021
With the introduction of `kube_listen_addr`, some users are confused on
how to set a public address for k8s access that's different from
`public_addr` of the proxy. `kube_public_addr` removes that confusion
and more closely resembles the other proxy endpoints.
This config:
```yaml
proxy_service:
kube_listen_addr: 0.0.0.0:3026
kube_public_addr: kube.example.com:3026
```
translates to the old format:
```yaml
proxy_service:
kubernetes:
enabled: yes
listen_addr: 0.0.0.0:3026
public_addr: kube.example.com:3026
```
awly
force-pushed
the
andrew/kube_public_addr
branch
from
6454348
to
d9a94bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of
kube_listen_addr, some users are confused onhow to set a public address for k8s access that's different from
public_addrof the proxy.kube_public_addrremoves that confusionand more closely resembles the other proxy endpoints.
This config:
translates to the old format:
Fixes #5110