Add additional Prometheus Metrics #6511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xacrimon
reviewed
Apr 21, 2021
| // MetricUserLoginCount counts user logins | ||
| MetricUserLoginCount = "user_login_count" | ||
|
|
||
| // MetricHeartbeatConnectionsReceived counts heartbeat connections received by auth |
There was a problem hiding this comment.
Not sure on the terminology but perhaps these would be better described as heartbeat messages? Correct me if I am wrong but I think a connection is persistently held and used for heartbeats.
There was a problem hiding this comment.
thanks for pointing this out because i did actually hook at the wrong place for heartbeat connections (in grpcserver.go )-- it should still be counting heartbeat connections but based on where i initally hooked -- i believe it counts messages. i will fix this.
quinqu
force-pushed
the
jane/add-prometheus-metrics
branch
from
6907b37
to
b138371
Compare
|
just randomly found this. hope it's ok if I rework this pr a bit to fit #6561 once it's reviewed and merged |
|
@fspmarshall @xacrimon Can you two review this PR? |
fspmarshall
approved these changes
Apr 27, 2021
|
@russjones can you review? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Extend Prometheus monitoring with various metrics
Implementation
Created counters for:
Original issue 6238
*This does not contain tracking network usage on each Teleport component, that will be a separate PR