Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy line support for mysql #6594

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Proxy line support for mysql #6594

merged 1 commit into from
Apr 30, 2021

Conversation

r0mant
Copy link
Collaborator

@r0mant r0mant commented Apr 26, 2021 •
edited
Loading

Add proxy protocol support to MySQL listener. Without this, MySQL access doesn't currently work in the Cloud. Fixes #6517.

Needs backport to 6.2.

@r0mant r0mant requested review from awly and fspmarshall April 26, 2021 16:27
@r0mant r0mant self-assigned this Apr 26, 2021
@r0mant r0mant added backport-required database-access Database access related issues and PRs labels Apr 26, 2021
@r0mant r0mant added this to the 6.2 "Buffalo" milestone Apr 26, 2021
Base automatically changed from roman/redshift to master April 26, 2021 18:53
@r0mant
Copy link
Collaborator Author

r0mant commented Apr 27, 2021

@awly @fspmarshall Could you folks take a look please?

awly
awly reviewed Apr 28, 2021
View reviewed changes
lib/multiplexer/wrappers.go Outdated Show resolved Hide resolved
lib/srv/db/mysql/engine.go Outdated Show resolved Hide resolved
lib/srv/db/mysql/proxy.go Outdated Show resolved Hide resolved
lib/multiplexer/wrappers.go Show resolved Hide resolved
lib/srv/db/mysql/proxy.go Outdated Show resolved Hide resolved
lib/srv/db/proxy_test.go Outdated Show resolved Hide resolved
lib/srv/db/proxy_test.go Outdated Show resolved Hide resolved
lib/srv/db/proxy_test.go Outdated Show resolved Hide resolved
lib/srv/db/proxy_test.go Outdated Show resolved Hide resolved
lib/srv/db/proxy_test.go Outdated Show resolved Hide resolved
@r0mant r0mant requested a review from awly April 29, 2021 01:58
awly
awly approved these changes Apr 29, 2021
View reviewed changes
lib/srv/db/mysql/engine.go Outdated Show resolved Hide resolved
lib/srv/db/mysql/engine.go Outdated Show resolved Hide resolved
@r0mant r0mant force-pushed the roman/mysqlproxyline branch 2 times, most recently from 4aa0cce to 9165cea Compare April 29, 2021 16:58
fspmarshall
fspmarshall approved these changes Apr 29, 2021
View reviewed changes
lib/srv/db/access_test.go Outdated Show resolved Hide resolved
@r0mant r0mant enabled auto-merge (squash) April 30, 2021 00:49
@r0mant r0mant mentioned this pull request Apr 30, 2021
Merged
@r0mant r0mant merged commit d0cfc8a into master Apr 30, 2021
russjones
russjones approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot.

@r0mant r0mant deleted the roman/mysqlproxyline branch April 30, 2021 01:03
@r0mant r0mant mentioned this pull request Apr 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awly awly awly approved these changes

@fspmarshall fspmarshall fspmarshall approved these changes

@russjones russjones russjones approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas

Assignees

@r0mant r0mant

Labels
backport-required database-access Database access related issues and PRs
Projects
None yet
Milestone
6.2 "Buffalo"
Development

Successfully merging this pull request may close these issues.

MySQL listener doesn't support proxy protocol
4 participants
@r0mant @awly @russjones @fspmarshall