-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mfa: strip trailing newline when reading TOTP codes #6948
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The newline should not be interpreted as part of the code (or any `prompt.Input` result).
awly
force-pushed
the
andrew/input-strip-whitespace
branch
from
May 19, 2021 18:35
c7ecce4
to
55a8bcd
Compare
andrejtokarcik
approved these changes
May 19, 2021
Joerger
approved these changes
May 19, 2021
Co-authored-by: Andrej Tokarčík <andrej@goteleport.com>
awly
force-pushed
the
andrew/input-strip-whitespace
branch
from
May 19, 2021 18:50
c876077
to
e942212
Compare
r0mant
approved these changes
May 19, 2021
awly
pushed a commit
that referenced
this pull request
May 19, 2021
The newline should not be interpreted as part of the code (or any `prompt.Input` result).
awly
pushed a commit
that referenced
this pull request
May 20, 2021
The newline should not be interpreted as part of the code (or any `prompt.Input` result).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The newline should not be interpreted as part of the code (or any
prompt.Input
result).Updates #6892