Correctly validate JWT CA on bootstrap #8119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
requested review from
klizhentas,
r0mant and
russjones
as code owners
|
Regarding my own question of whether we should keep checkResourceConsistency, the answer is yes - we won't guarantee that local CAs have keys otherwise (ValidateCertAuthority checks existing keys, but does not ensure that keys are present). |
fspmarshall
approved these changes
Sep 1, 2021
|
Thanks for the super fast review, Forrest. |
zmb3
approved these changes
Sep 1, 2021
klizhentas
approved these changes
Sep 1, 2021
Found out when the code formatter added a space to the comment.
codingllama
force-pushed
the
codingllama/bootstrap-fix
branch
from
73168f9
to
a1f9209
Compare
codingllama
added a commit
that referenced
this pull request
Sep 2, 2021
Presently, teleport start --bootstrap state.yaml fails due to incorrect handling of JWT CAs, even when the data is generated using tctl get all --with-secrets. Backport of #8119.
zmb3
pushed a commit
that referenced
this pull request
Sep 23, 2021
Presently, teleport start --bootstrap state.yaml fails due to incorrect handling of JWT CAs, even when the data is generated using tctl get all --with-secrets. Fixes #7853. * Correctly validate JWT CertAuthorities on bootstrap * Remove commented code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently,
teleport start --bootstrap state.yamlfails due to incorrecthandling of JWT CAs, even when the data is generated using
tctl get all --with-secrets.Fixes #7853.