Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API release automation with go script #8484
API release automation with go script #8484
Changes from 11 commits
8cc6462
f1c0406
2c9aaab
0639da3
9da8c2d
859e25f
316253c
35b2cc9
5d5b85f
2466b16
ac1aa2c
68710ec
0b2141e
1f4a5d8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love the subtle difference between these two cases. Any way we can figure out the nasty relative path ahead of time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For linux we could use
ln -r
andreadlink
, but I'm not sure what else we could do to keep this os independent. I tried searching a bit but didn't find anything.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to write a platform-independent version in Go, perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to keep build steps and dev tools in bash/Make, or at least that's been the preference thus far. This PR itself is a bit of an edge case since updating the go module import path specifically benefits from using Go due to the
golang.org/x/tools
package. If we want to move towards go scripts or something similar, it should probably be a more discussed and deliberate effort.