Updated Session URL #906
Merged
Updated Session URL #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russjones
force-pushed
the
rjones/teleport-status
branch
from
d2027fc
to
3aa5992
Compare
klizhentas
reviewed
Apr 7, 2017
tool/teleport/common/teleport.go
Outdated
| @@ -182,13 +182,23 @@ func onStart(config *service.Config) error { | |||
| func onStatus() error { | |||
| sid := os.Getenv("SSH_SESSION_ID") | |||
| proxyHost := os.Getenv("SSH_SESSION_WEBPROXY_ADDR") | |||
| tuser := os.Getenv("SSH_TELEPORT_USER") | |||
| teleportUser := os.Getenv("SSH_TELEPORT_USER") | |||
There was a problem hiding this comment.
constant used more than once, makes sense to make it real constant, otherwise LGTM
russjones
force-pushed
the
rjones/teleport-status
branch
from
3aa5992
to
2646cdf
Compare
klizhentas
approved these changes
Apr 7, 2017
russjones
force-pushed
the
rjones/teleport-status
branch
from
2646cdf
to
4b95db4
Compare
hatched
pushed a commit
to hatched/teleport-merge
that referenced
this pull request
Nov 30, 2022
hatched
pushed a commit
that referenced
this pull request
Dec 20, 2022
hatched
pushed a commit
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As reported in #900, the output of
teleport statusis currently incorrect. The path to a session has changed and the output ofteleport statushas not beed updated.Implementation
lib/srv/exec.gowe now exportSSH_TELEPORT_HOST_UUIDandSSH_TELEPORT_CLUSTER_NAMEas these are ended to construct the path to a session now.tool/teleport/common/teleport.gowe now list the Host UUID and Cluster Name in addition to the corrected Session URL.Related Issues
Fixes #900