Don't set logins directly from allowed logins for CertAuthority V2. #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russjones
force-pushed
the
rjones/trusted-cluster-fix
branch
from
917fb99
to
a77bb81
Compare
klizhentas
reviewed
Apr 11, 2017
docker/README.md
Outdated
| @@ -87,6 +87,37 @@ To setup Trusted Clusters: | |||
| tctl -c /root/go/src/github.com/gravitational/teleport/docker/two-auth.yaml create -f docker/two-tc.yaml | |||
| ``` | |||
|
|
|||
| #### Trusted Clusters with File Configuration | |||
|
|
|||
| 1. Export the CA for both clusters: | |||
There was a problem hiding this comment.
numbered lists don't look that good in the docs really, consider adding subtitles instead to separate sections
Export keys
klizhentas
reviewed
Apr 11, 2017
russjones
force-pushed
the
rjones/trusted-cluster-fix
branch
2 times, most recently
from
0e46849
to
7f19f6c
Compare
russjones
force-pushed
the
rjones/trusted-cluster-fix
branch
from
7f19f6c
to
c4f0b81
Compare
hatched
pushed a commit
to hatched/teleport-merge
that referenced
this pull request
Nov 30, 2022
hatched
pushed a commit
that referenced
this pull request
Dec 20, 2022
hatched
pushed a commit
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As covered in #918, when you export CAs using the new style format, you will see the following in the Web UI:
The reason is because we were settings logins directly from allowed logins. This PR changes this behavior to match the behavior for how we parse CAs in the
known_hostsformat, we don't set logins directly but rather create a role first and add the role to the CertAuthority.Implementation
allowedLogins.Related Issues
Fixes #918