This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Fix null role response from users fetch #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlisa
force-pushed
the
lisa/fix-null-user-role-array
branch
from
1234167 to
fc4d55b
Compare
hatched
approved these changes
Jun 7, 2022
kimlisa
added a commit
that referenced
this pull request
Jun 7, 2022
kimlisa
added a commit
that referenced
this pull request
Jun 7, 2022
kimlisa
added a commit
to gravitational/webassets
that referenced
this pull request
Jun 7, 2022
kimlisa
added a commit
to gravitational/teleport
that referenced
this pull request
Jun 7, 2022
bbb35a39 Fix null role response from users fetch (gravitational/webapps#871) (gravitational/webapps#872) gravitational/webapps@bbb35a39 [source: -w teleport-v9] [target: -t branch/v9]
kimlisa
added a commit
to gravitational/teleport
that referenced
this pull request
Jun 8, 2022
bbb35a39 Fix null role response from users fetch (gravitational/webapps#871) (gravitational/webapps#872) gravitational/webapps@bbb35a39 [source: -w teleport-v9] [target: -t branch/v9]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a user ran into an issue in the UI where
cannot read properties of null (reading 'sort')when listing users: https://goteleport.slack.com/archives/CEZH6UL64/p1654536009001459I was able to replicate this issue by modifying a user's yaml file through
tctland delete therolefield, andtctl create user.yaml -f. A user can exist with no roles which returns asnullfrom the back, which wasn't handled in the UI.