feat(flows): add application flows #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leleueri
reviewed
Jan 15, 2021
| existingFlows = new HashSet<>(); | ||
| } | ||
| ExecutionFlow executionFlow = new ExecutionFlow(flow, executionPolicies); | ||
| existingFlows.remove(executionFlow); |
There was a problem hiding this comment.
Because existingFlows is a Set, from my point of view the remove call is useless
leleueri
reviewed
Jan 15, 2021
| if (existingFlows == null || existingFlows.isEmpty()) { | ||
| return; | ||
| } | ||
| existingFlows.removeIf(executionFlow -> flowId.equals(executionFlow.getFlowId())); |
There was a problem hiding this comment.
why not a simple remove? ExecutionFlow equals & hasCode are based on the FlowId, result will be the same as far as I can say with a simplest code.
tcompiegne
force-pushed
the
issues/#4764-application-flows
branch
from
b1f4179 to
02b2205
Compare
leleueri
force-pushed
the
issues/#4764-application-flows
branch
2 times, most recently
from
1e2907a to
24e39f3
Compare
tcompiegne
force-pushed
the
issues/#4764-application-flows
branch
from
24e39f3 to
474f98d
Compare
tcompiegne
force-pushed
the
issues/#4764-application-flows
branch
from
474f98d to
6d4e8c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes gravitee-io/issues#4764