Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: introduce implicit consent settings for the IP & user agent #2091

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

leleueri
Copy link
Contributor

fixes gravitee-io/issues#8448

📝 Test scenarios

  • Start the GW with the following settings or env vars:

[settings]

consent:
  ip: true
  user-agent: true

[env var]

gravitee_consent_ip=true
gravitee_consent_useragent=true
  • sign in a user and enroll webauthn
  • check into the audit 'USER_LOGIN' event contains the IP address and the UserAgent
  • check into the user profile, the credentials details contains the IP address and the UserAgent

@leleueri leleueri requested a review from a team as a code owner September 14, 2022 18:26
@leleueri leleueri force-pushed the issues/#8448-implicit-consent4logs branch from 5d01746 to 6b8436b Compare September 16, 2022 06:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

72.7% 72.7% Coverage
0.0% 0.0% Duplication

@leleueri leleueri merged commit cb500d3 into 3.18.x Sep 16, 2022
@leleueri leleueri deleted the issues/#8448-implicit-consent4logs branch September 16, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants