Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AM-87 Update the certificate used by applications after a default cer… #2222

Merged
merged 1 commit into from
Nov 21, 2022
Merged

AM-87 Update the certificate used by applications after a default cer… #2222

merged 1 commit into from
Nov 21, 2022

Conversation

leleueri
Copy link
Contributor

@leleueri leleueri commented Nov 9, 2022 •
edited
Loading

…t renewal

How to test

  • Create a new domain
  • create an app
  • check the app certificate is set to Default
  • go to domain settings > certificate
  • click on "Rotate System Key"
  • wait 10 minutes (default value for the application update delay)
  • check the app certificate is set to "Default yyyy-MM-dd HH:mm:ss"
  • check into the audit logs of the domain that application has been updated by the actor "system" and into the audit detail, only the certificate field is present
  • try to initiate the login flow for this application to get an access_token. The access-token should be signed using the default certificate assign to the application.

@leleueri leleueri requested a review from a team as a code owner November 9, 2022 16:14
@leleueri leleueri force-pushed the AM-87-rotation-key-assign-certificate-to-the-apps branch 2 times, most recently from cc43d64 to 4267ed9 Compare November 15, 2022 20:52
@leleueri leleueri force-pushed the AM-87-rotation-key-assign-certificate-to-the-apps branch 2 times, most recently from 5bb8822 to a57f196 Compare November 17, 2022 13:33
@leleueri leleueri force-pushed the AM-87-rotation-key-assign-certificate-to-the-apps branch from a57f196 to e6e54ac Compare November 17, 2022 13:51
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 17, 2022 •
edited
Loading

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

8.8% 8.8% Coverage
0.0% 0.0% Duplication

@ashraf706 ashraf706 merged commit 979e7b6 into master Nov 21, 2022
@ashraf706 ashraf706 deleted the AM-87-rotation-key-assign-certificate-to-the-apps branch November 21, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashraf706 ashraf706 ashraf706 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leleueri @ashraf706