Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apim 7783 mapi verify tcp and kafka hosts #10177

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Apim 7783 mapi verify tcp and kafka hosts #10177

merged 3 commits into from
Dec 20, 2024

Conversation

jourdiw
Copy link
Contributor

@jourdiw jourdiw commented Dec 18, 2024 •
edited by graviteeio
Loading

Issue

https://gravitee.atlassian.net/browse/APIM-7783

Description

  • Do not allow uppercase letters for TCP hosts.
  • Add backend verification for Kafka hosts.
  • Update Console to add in listenerType as a request param for /apis/_verify/hosts.

Additional context

📚  View the storybook of this branch here

@jourdiw jourdiw marked this pull request as ready for review December 19, 2024 09:40
@jourdiw jourdiw requested a review from a team as a code owner December 19, 2024 09:40
ThibaudAV
ThibaudAV approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@ThibaudAV ThibaudAV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jourdiw jourdiw merged commit 48e773a into master Dec 20, 2024
19 checks passed
@jourdiw jourdiw deleted the apim-7783-mapi-verify-tcp-and-kafka-hosts branch December 20, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaudAV ThibaudAV ThibaudAV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jourdiw @ThibaudAV