Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-1616:add fix for checking gateway issue #881

Merged
merged 2 commits into from
Sep 17, 2024
Merged

NET-1616:add fix for checking gateway issue #881

merged 2 commits into from
Sep 17, 2024

Conversation

yabinma
Copy link
Collaborator

@yabinma yabinma commented Sep 16, 2024

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

Copy link
Collaborator

@lmnzx lmnzx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested And Passed

@abhishek9686 abhishek9686 merged commit 7ed4cf4 into develop Sep 17, 2024
14 checks passed
yabinma added a commit that referenced this pull request Sep 20, 2024
NET-1616:add fix for checking gateway issue (#881)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants