feat(Higcharts plugin): add type for manageTooltipConfig #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
korvin89
commented
Mar 20, 2023
| @@ -267,7 +267,7 @@ function initHighcharts({isMobile}) { | |||
|
|
|||
| Highcharts.wrap(Highcharts.Tooltip.prototype, 'hide', function (proceed, ...rest) { | |||
| if (this.lastVisibleRowIndex) { | |||
| this.lastVisibleRowIndex = null; | |||
| this.lastVisibleRowIndex = undefined; | |||
There was a problem hiding this comment.
Change null by undefined for consistency
korvin89
commented
Mar 21, 2023
| allowComment: selectedLineIndex > tooltip.lastVisibleRowIndex, | ||
| allowComment: | ||
| typeof tooltip.lastVisibleRowIndex === 'number' && | ||
| selectedLineIndex > tooltip.lastVisibleRowIndex, |
There was a problem hiding this comment.
It was broke because of tooltip.lastVisibleRowIndex sometimes had null value, and
selectedLineIndex > tooltip.lastVisibleRowIndex // true
Flunt1k
approved these changes
Mar 21, 2023
This was referenced Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: