Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(notifications): remove tinygesture #94

Merged
merged 1 commit into from
Aug 22, 2023
Merged

feat(notifications): remove tinygesture #94

merged 1 commit into from
Aug 22, 2023

Conversation

Lakate
Copy link
Contributor

@Lakate Lakate commented Aug 21, 2023

No description provided.

@Lakate Lakate requested a review from Ruminat August 21, 2023 16:01
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@Lakate
Copy link
Contributor Author

Lakate commented Aug 21, 2023 •
edited
Loading

I added a HorizontalSwiper with the necessary code from tinygesture and removed the import of the library
Check it here https://preview.gravity-ui.com/components/94/?path=/story/components-notifications--default

Ruminat
Ruminat reviewed Aug 21, 2023
View reviewed changes
src/components/Notification/components/HorizontalSwiper/HorizontalSwiper.ts Outdated
@@ -0,0 +1,195 @@
export interface Options {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mention the source with this url — https://github.com/sciactive/tinygesture/blob/master/src/TinyGesture.ts

@ogonkov
Copy link
Contributor

ogonkov commented Aug 21, 2023

Do not add space symbol after feat and before opening parenthesis

@Lakate Lakate force-pushed the lakate/CLOUDFRONT-19032/remove-tinygesture branch from c1f32f2 to 31229a2 Compare August 21, 2023 16:15
@Lakate Lakate changed the title feat (notifications): remove tinygesture feat(notifications): remove tinygesture Aug 21, 2023
@Ruminat
Copy link
Contributor

Ruminat commented Aug 22, 2023

The tinygesture library is still in package.json and package-lock.json

@Lakate Lakate force-pushed the lakate/CLOUDFRONT-19032/remove-tinygesture branch from 31229a2 to 7a5bb70 Compare August 22, 2023 09:26
@Lakate Lakate merged commit 83c795a into main Aug 22, 2023
@Lakate Lakate deleted the lakate/CLOUDFRONT-19032/remove-tinygesture branch August 22, 2023 09:46
@gravity-ui-bot gravity-ui-bot mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ruminat Ruminat Ruminat approved these changes

@korvin89 korvin89 korvin89 approved these changes

@amje amje Awaiting requested review from amje amje is a code owner

@ValeraS ValeraS Awaiting requested review from ValeraS ValeraS is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lakate @gravity-ui-bot @ogonkov @Ruminat @korvin89