Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overlay-menu-handler-item #57

Merged
merged 1 commit into from
Apr 18, 2023
Merged

feat: overlay-menu-handler-item #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/OverlayControls/OverlayControls.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {
MenuItemProps,
} from '@gravity-ui/uikit';
import {COPIED_WIDGET_STORE_KEY, MenuItems} from '../../constants';
import {ConfigLayout, ConfigItem, PluginBase, StringParams, Config} from '../../shared';
import {ConfigLayout, ConfigItem, PluginBase, StringParams, Config, ItemState} from '../../shared';
import type {RegisterManager} from '../../utils/register-manager';
import {DotsIcon} from '../../icons/DotsIcon';
import {CogIcon} from '../../icons/CogIcon';
Expand Down Expand Up @@ -48,7 +48,7 @@ export interface OverlayCustomControlItem {
title?: string;
icon?: MenuItemProps['icon'];
iconSize?: number | string;
handler?: (item: ConfigItem, params: StringParams) => void;
handler?: (item: ConfigItem, params: StringParams, state: ItemState) => void;
visible?: (item: ConfigItem) => boolean;
className?: string;
qa?: string;
Expand All @@ -69,6 +69,7 @@ interface OverlayControlsProps extends OverlayControlsDefaultProps {
type DashKitCtx = React.Context<{
registerManager: RegisterManager;
itemsParams: Record<string, StringParams>;
itemsState: Record<string, ItemState>;
editItem: (item: ConfigItem) => void;
removeItem: (id: string) => void;
config: Config;
Expand Down Expand Up @@ -209,10 +210,11 @@ class OverlayControls extends React.Component<OverlayControlsProps> {
}
private renderDropdownMenu() {
const {view, size} = this.props;
const {registerManager, itemsParams} = this.context;
const {registerManager, itemsParams, itemsState} = this.context;

const configItem = this.props.configItem;
const itemParams = itemsParams[configItem.id];
const itemState = itemsState[configItem.id];

let menu = registerManager.settings.menu as any;
if (!menu.length) {
Expand All @@ -236,7 +238,7 @@ class OverlayControls extends React.Component<OverlayControlsProps> {

const itemAction =
typeof itemHandler === 'function'
? () => itemHandler(configItem, itemParams)
? () => itemHandler(configItem, itemParams, itemState)
: this.getDropDownMenuItemConfig(item.id)?.action || (() => {});

return {
Expand Down