Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

natural=mud appearing later than natural=sand/beach (z13 vs z10) #1018

Closed
malcolmh opened this issue Oct 6, 2014 · 10 comments · Fixed by #1036
Closed

natural=mud appearing later than natural=sand/beach (z13 vs z10) #1018

malcolmh opened this issue Oct 6, 2014 · 10 comments · Fixed by #1036

Comments

@malcolmh
Copy link

malcolmh commented Oct 6, 2014

natural=sand/beach and tidal=yes appear at zoom 10
natural=mud and tidal=yes appear at zoom 13

@matkoniecz
Copy link
Contributor

Note that tidal tag not used by this style (see https://github.com/gravitystorm/openstreetmap-carto/blob/master/openstreetmap-carto.style - it is skipped during importing data into a database).

@matkoniecz matkoniecz changed the title Inconsistent rendering on natural=* tidal=yes natural=mud appearing later than natural=sand/beach (z13 vs z10) Oct 6, 2014
@matkoniecz
Copy link
Contributor

Can you give an example of place where it leads to a bad rendering?

@matkoniecz
Copy link
Contributor

related to #420

@malcolmh
Copy link
Author

malcolmh commented Oct 7, 2014

http://www.openstreetmap.org/#map=13/53.6174/0.0715

Here there is both mud and sand areas adjacent to each other. At z10, 11 & 12 only the sand is rendered, creating an 'island' of sand. In reality this is a single, continuous tidal flat.

@dieterdreist
Copy link

2014-10-07 8:46 GMT+02:00 Malcolm Herring notifications@github.com:

http://www.openstreetmap.org/#map=13/53.6174/0.0715

Here there is both mud and sand areas adjacent to each other. At z10, 11 &
12 only the sand is rendered, creating an 'island' of sand. In reality this
is a single, continuous tidal flat.

according to the wiki definition of the key "natural", both, sand and mud,
are malformed values and should not be used, while "beach" is fine as it
describes a geographical feature. I suggest to push moving "mud" and "sand"
under another key like "landcover" or "surface".

@matkoniecz
Copy link
Contributor

@dieterdreist Well, both "mud" and "sand" are currently rendered. You may want to open a separate ticket.

@dieterdreist
Copy link

2014-10-07 14:29 GMT+02:00 Mateusz Konieczny notifications@github.com:

@dieterdreist https://github.com/dieterdreist Well, both "mud" and
"sand" are currently rendered. You may want to open a separate ticket.

done
#1025

@malcolmh
Copy link
Author

malcolmh commented Oct 7, 2014

"not according to the Wiki" Where? On the main map features page, natural=mud/sand/beach are all documented, with the renderings that do appear. Where does it say that they are "malformed"?
The only other pages that I could find suggest wetland=* tag might be used instead, but no mention as to the renderer status of these alternatives.

@matkoniecz matkoniecz self-assigned this Oct 7, 2014
@matkoniecz
Copy link
Contributor

I consider this as a bug caused by #420

@matthijsmelissen matthijsmelissen added this to the Bugs and improvements milestone Oct 9, 2014
@matkoniecz
Copy link
Contributor

#899 is next in this group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants