-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering for wayside_shrine #131
Comments
The use of a cross symbol for the shrine, at least without religion=christian, could lead to problems. |
Then put a star on it instead of a cross. N.B.: There are 3224 historic=wayside_shrine only within Austria. Those are BTW all christian. It's not that important what the symbol looks like. But it is important to render them! When invented, historic=wayside_shrine always was meant "denominational". It's perfekt to tag "non-denominational" memorials with historic=memorial, isn't it. |
Not even all Christian denominations use crosses. See #75 |
I propose following rendering: historic=wayside_cross as a cross, with suitable variations based on a religion tag. wayside_shrine: as a small religion symbol, with selection in the same way as it is done with place of worship (including no religion by default). Both rendered from z17 (z18?) |
Official maps have different symbols for Bildstock (aka Marterl aka wayside shrine), Bildbaum (wayside shrine or cross together with natural=tree) and Wegkreuz (wayside cross). To make things simple, the standard OSM religious would be ok. z17 would be great (place of worship is rendered starting z16, AFAICT). /al |
My proposition for shrine (also 9 px as cross made by @matkoniecz): |
@kocio-pl |
I guess 2 is better as a general shrine (with 1 for christian), so I'll try to make some mockups soon. |
#131 (comment) - can you upload a SVG file (or is it only a png mockup)? |
Initial effects are promising, but I will try to tweak icon to make it less heavy. Below is an extreme example, but also single shrines are too prominent. |
IMO wayside_cross/_shrine (and even chapel) icons should be smaller than a church cross icon. |
Yes, obviously here shrines are way too prominent. On topic of crosses - it is a good point. Either PoW symbols should have chance to appear earlier or crosses should appear later. |
sent from a phone
the churches (and other PoW) could probably appear earlier, but regardless of that I share the point that wayside shrines and crosses should be less prominent in general compared to them. One way would be to reduce the cross size in the icon. |
@matkoniecz Those objects are the perfect examples of #1705 to me: in the outdoor they could be OK, but in the city they are just making noise on this zoom level. |
Do we think the problem of shrine rendering can be solved or no good enough solution is currently at the table and it's rather to be closed? |
I think that it can be solved, but recently I had no available time to do anything with it. |
Any new ideas? |
Since we have no solution for a long time, I guess we should close it now. If someone comes with an idea, this could be reopened. |
What if we start rendering them later (like z18+) with proposed design? |
Sounds good to me ; the icon seems OK and that really could help general users to have these landmarks. |
I will wait for additional comments, but that means it's worth to reopen this issue. Code should be rather easy to prepare if we reach agreement here. |
You mean the proposed symbol in the original post? I agree. |
Yep, I think both of them are fine, let's go for them. |
Do you plan to have one universal shape instead of christian+generic? |
I think that Christian + generic is preferable. For start, version with cross is much easier to recognize (I am not sure whatever generic ones are worth rendering) and strongly encourages adding religion tag at least some shrines. |
I think they are, because they are common orientation points in the outdoor. That's why I still try to render them, otherwise we could just render christian shrines the same as wayside crosses (which was proposed at some point). |
I agree that with good, recognizable icon rendering them would be a good idea. I have doubts about rendering them with icon that I tried or see here. |
@Tomasz-W Could you publish this shape as gist, so I could try it? |
@Tomasz-W Thanks again for your design, it was one of the oldest issues alive and I'm happy that it's done at last!... It looks like sometimes trying to make the icon smaller is worse than having full size icon but with a lighter color - good lesson. |
Fun fact: 1642 days passed between opening this issue and merge the icon ;) |
The oldest (re)open(ed) issue ticket is from 11 Jun 2013, so only about 2 months older than this... |
BTW: are you sure that all these shrines should be tagged as |
This is a poor place to invent new tags - such things should be discussed on @tagging mailing list. |
I know, it's just a thought related to the example you gave here. |
Wish: Please render historic=wayside_cross and wayside_shrine, they are landmarks.
wayside_cross could be rendered much like any christian place of worship:
wayside_shrine symbol could be something like
The text was updated successfully, but these errors were encountered: