Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for wayside_shrine #131

Closed
al-- opened this issue Aug 23, 2013 · 45 comments
Closed

Add rendering for wayside_shrine #131

al-- opened this issue Aug 23, 2013 · 45 comments
Assignees
Labels
amenity-points enhancement new features Requests to render new features
Milestone

Comments

@al--
Copy link

al-- commented Aug 23, 2013

Wish: Please render historic=wayside_cross and wayside_shrine, they are landmarks.

wayside_cross could be rendered much like any christian place of worship:
wayside_cross

wayside_shrine symbol could be something like wayside_shrine

@brycenesbitt
Copy link

The use of a cross symbol for the shrine, at least without religion=christian, could lead to problems.
A way to represent multi- or non-denominational memorials is needed.

@al--
Copy link
Author

al-- commented Aug 24, 2013

Then put a star on it instead of a cross.

N.B.: There are 3224 historic=wayside_shrine only within Austria. Those are BTW all christian. It's not that important what the symbol looks like. But it is important to render them!

When invented, historic=wayside_shrine always was meant "denominational". It's perfekt to tag "non-denominational" memorials with historic=memorial, isn't it.

@brycenesbitt
Copy link

Not even all Christian denominations use crosses. See #75
Around here there are plenty of wayside shrines: maybe 50% are Christian.

@matthijsmelissen matthijsmelissen added this to the New features milestone Aug 18, 2014
@matthijsmelissen matthijsmelissen changed the title Wish: render wayside_cross and wayside_shrine Add rendering for wayside_cross and wayside_shrine Sep 24, 2014
@matkoniecz
Copy link
Contributor

I propose following rendering: historic=wayside_cross as a cross, with suitable variations based on a religion tag.

wayside_shrine: as a small religion symbol, with selection in the same way as it is done with place of worship (including no religion by default).

Both rendered from z17 (z18?)

@matkoniecz matkoniecz self-assigned this Oct 11, 2014
@al--
Copy link
Author

al-- commented Oct 12, 2014

Official maps have different symbols for Bildstock (aka Marterl aka wayside shrine), Bildbaum (wayside shrine or cross together with natural=tree) and Wegkreuz (wayside cross).

wayside shrine, wayside cross

To make things simple, the standard OSM religious would be ok.

z17 would be great (place of worship is rendered starting z16, AFAICT).

Bildstock, Bildbaum, Wegkreuz

/al

@kocio-pl
Copy link
Collaborator

My proposition for shrine (also 9 px as cross made by @matkoniecz):

  1. shrine-9-11

@matkoniecz
Copy link
Contributor

@kocio-pl
Shrines need also symbols for other religion values. At least for religion=* missing (over 80% of entries), religion values except 'christian' are quite rare (though buddhist and taoist are noticeable in http://overpass-turbo.eu/s/aD8 ).

@kocio-pl
Copy link
Collaborator

First has only vertical stick left, the second one is just a box with no stick on top:
2) shrine-9-12
3) shrine-9-13

@kocio-pl
Copy link
Collaborator

I guess 2 is better as a general shrine (with 1 for christian), so I'll try to make some mockups soon.

@Penegal
Copy link
Contributor

Penegal commented Sep 15, 2015

If it helps, another possibility for wayside cross, widespread in France : wayside cross

@matkoniecz
Copy link
Contributor

My proposition for shrine (also 9 px as cross made by @matkoniecz):

#131 (comment) - can you upload a SVG file (or is it only a png mockup)?

@kocio-pl
Copy link
Collaborator

@matkoniecz Here you are.

@matkoniecz
Copy link
Contributor

Initial effects are promising, but I will try to tweak icon to make it less heavy. Below is an extreme example, but also single shrines are too prominent.

selection_001
http://www.openstreetmap.org/#map=16/50.0561/19.9372

@al--
Copy link
Author

al-- commented Sep 24, 2015

IMO wayside_cross/_shrine (and even chapel) icons should be smaller than a church cross icon.

@matkoniecz
Copy link
Contributor

Yes, obviously here shrines are way too prominent. On topic of crosses - it is a good point. Either PoW symbols should have chance to appear earlier or crosses should appear later.

@dieterdreist
Copy link

sent from a phone

Am 24.09.2015 um 10:28 schrieb Mateusz Konieczny notifications@github.com:

Either PoW symbols should have chance to appear earlier or crosses should appear later.

the churches (and other PoW) could probably appear earlier, but regardless of that I share the point that wayside shrines and crosses should be less prominent in general compared to them. One way would be to reduce the cross size in the icon.

@al--
Copy link
Author

al-- commented Sep 24, 2015

Here's how the (official) BEV does ist: It's smaller, not only the cross, but especially what's underneath.

marterl_karte

A cross with something underneath is typically always more prominent than just a cross.

@kocio-pl
Copy link
Collaborator

@matkoniecz Those objects are the perfect examples of #1705 to me: in the outdoor they could be OK, but in the city they are just making noise on this zoom level.

@kocio-pl
Copy link
Collaborator

Do we think the problem of shrine rendering can be solved or no good enough solution is currently at the table and it's rather to be closed?

@matkoniecz
Copy link
Contributor

I think that it can be solved, but recently I had no available time to do anything with it.

@kocio-pl
Copy link
Collaborator

Any new ideas?

@kocio-pl kocio-pl changed the title Add rendering for wayside_cross and wayside_shrine Add rendering for wayside_shrine Dec 15, 2016
@kocio-pl
Copy link
Collaborator

Since we have no solution for a long time, I guess we should close it now. If someone comes with an idea, this could be reopened.

@kocio-pl
Copy link
Collaborator

What if we start rendering them later (like z18+) with proposed design?

@Penegal
Copy link
Contributor

Penegal commented Oct 30, 2017

Sounds good to me ; the icon seems OK and that really could help general users to have these landmarks.

@kocio-pl
Copy link
Collaborator

I will wait for additional comments, but that means it's worth to reopen this issue. Code should be rather easy to prepare if we reach agreement here.

@kocio-pl kocio-pl reopened this Oct 30, 2017
@kocio-pl kocio-pl self-assigned this Oct 30, 2017
@PontiacCZ
Copy link

You mean the proposed symbol in the original post? I agree.

@kocio-pl
Copy link
Collaborator

I mean both christian and non-christian icons:

  1. shrine-9-11
  2. shrine-9-12

@PontiacCZ
Copy link

Yep, I think both of them are fine, let's go for them.

@Tomasz-W
Copy link

Tomasz-W commented Jan 8, 2018

For me, it's not representing common-known shrine shape enough. What about classic wayside shrines shape?

historic wayside_shrine2

14x14: historic wayside_shrine
14x14 (brown): historic wayside_shrine brown

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 8, 2018

Do you plan to have one universal shape instead of christian+generic?

@matkoniecz
Copy link
Contributor

Do you plan to have one universal shape instead of Christian+generic?

I think that Christian + generic is preferable. For start, version with cross is much easier to recognize (I am not sure whatever generic ones are worth rendering) and strongly encourages adding religion tag at least some shrines.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 8, 2018

I am not sure whatever generic ones are worth rendering

I think they are, because they are common orientation points in the outdoor. That's why I still try to render them, otherwise we could just render christian shrines the same as wayside crosses (which was proposed at some point).

@matkoniecz
Copy link
Contributor

I agree that with good, recognizable icon rendering them would be a good idea. I have doubts about rendering them with icon that I tried or see here.

@kocio-pl
Copy link
Collaborator

@Tomasz-W Could you publish this shape as gist, so I could try it?

@Tomasz-W
Copy link

@kocio-pl
Copy link
Collaborator

@Tomasz-W Thanks again for your design, it was one of the oldest issues alive and I'm happy that it's done at last!... It looks like sometimes trying to make the icon smaller is worse than having full size icon but with a lighter color - good lesson.

@Tomasz-W
Copy link

Fun fact: 1642 days passed between opening this issue and merge the icon ;)

@kocio-pl
Copy link
Collaborator

The oldest (re)open(ed) issue ticket is from 11 Jun 2013, so only about 2 months older than this...

@kocio-pl
Copy link
Collaborator

@matkoniecz

Below is an extreme example, but also single shrines are too prominent.

BTW: are you sure that all these shrines should be tagged as historic=wayside_shrine? Maybe they should be retagged as man_made=shrine, just like we do with crosses?

@matkoniecz
Copy link
Contributor

BTW: are you sure that all these shrines should be tagged as historic=wayside_shrine? Maybe they should be retagged as man_made=shrine, just like we do with crosses?

This is a poor place to invent new tags - such things should be discussed on @tagging mailing list.

@kocio-pl
Copy link
Collaborator

I know, it's just a thought related to the example you gave here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amenity-points enhancement new features Requests to render new features
Projects
None yet
Development

No branches or pull requests

10 participants