Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special rendering for shop=alcohol and shop=beverages #1407

Closed
kocio-pl opened this issue Mar 18, 2015 · 12 comments
Closed

Add special rendering for shop=alcohol and shop=beverages #1407

kocio-pl opened this issue Mar 18, 2015 · 12 comments

Comments

@kocio-pl
Copy link
Collaborator

We should start rendering shop=alcohol and shop=beverages, probably with this icon from osmfr-cartocss fork:

https://github.com/cquest/osmfr-cartocss/blob/master/symbols/alcohol.svg

[It was proposed in meta-issue #1402]

@kocio-pl kocio-pl changed the title Add rendering for shop=alcohol and shop=beverages Add special rendering for shop=alcohol and shop=beverages Mar 18, 2015
@nebulon42
Copy link
Contributor

alcohol-18.svg: alcohol-18

@kocio-pl
Copy link
Collaborator Author

Both the bottle and the glass could be taller, I think, but otherwise it's good icon.

@nebulon42
Copy link
Contributor

What is the distinction to beverages? Should both use the same icon?

@kocio-pl
Copy link
Collaborator Author

It looks like beverages can be both alcoholic and non-alcoholic:

so probably we need also a generic icon for all the beverages.

@matthijsmelissen
Copy link
Collaborator

A percentage symbol is often used to indicate alcohol.

@kocio-pl
Copy link
Collaborator Author

Maybe beverages shop should have a bottle+cup pair instead of bottle+glass?

@dieterdreist
Copy link

2015-04-21 0:15 GMT+02:00 kocio-pl notifications@github.com:

Maybe beverages shop should have a bottle+cup pair instead of bottle+glass?

I would think about a cafe and not about soft drinks when seeing a cup. All
beverages shops I have ever been to were selling soft drinks, juices,
water, beer, wine, maybe spirits but not tea or coffee and not even milk.

@kocio-pl
Copy link
Collaborator Author

I meant glass like this (wider-on-top and thinner-on-bottom shape would be easier to recognize than rectangle), but was unable to tell it exactly in English - in Polish we have "szklanka" for cool beverages, "kieliszek" for an alcohol and "kubek" for hot beverages. =}

@kocio-pl
Copy link
Collaborator Author

I've just found the shape I was looking for: real glass and the icon.

@kocio-pl
Copy link
Collaborator Author

My proposition for shop=beverages based on shop=alcohol from Osmic: beverages-14

@kocio-pl
Copy link
Collaborator Author

Even better version (mainly as a proof of concept, technically I'm just a newbie with Inkscape): beverages-14

@kocio-pl
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants