-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add icons for popular shop types #1493
Conversation
…t, jewelry/jewellery, mobile_phone and optician (resolves gravitystorm#1415 gravitystorm#1412 gravitystorm#1408)
For Jewelry, I also like an icon like this: http://wiki.openstreetmap.org/wiki/File:Shop-jewelry.svg Simpler than the ring, and the simpler the better on this scale, I guess. |
I had a try with the diamond, but the inverse version of what you linked here did not work out. I'm not sure regarding the linked version, it's rather noisy for me. I seriously considered the diamond, but then moved towards the ring in the end. |
Ok, good that you had a look at it at least! |
Wiki has "shop=alcohol Shop selling alcoholic drinks" and "shop=beverages Shop focused on selling alcoholic and non-alcoholic beverages.". |
Maybe shop=beverages may have something else rather than wine glass? Second bottle? Can? |
it's mainly a cultural distinction, in countries with restricted sale of alcohol (e.g. USA, Iran) there are special alcohol shops, while in other countries you will get alcohol also in "normal" beverage shops, but also in these countries there will typically be shops that sell alcohol only, often just of some particular kind (typically high quality), like wine or whiskey. |
Ok, so beverages should be distinct. I will work on that later. Any further comments on these icons? |
optician, mobile_phone and gift seem fine to me. furniture i would make the 'line' less prominent - right now it appears to be a two part object jewelry seems too abstract to be easily recognizable - could also resemble some kind of doll/puppet or some technical stuff. electronics seems ambiguous - could also mean a kind of public viewing location. |
2015-04-20 23:34 GMT+02:00 nebulon42 notifications@github.com:
There is also the tag shop=wine (used 1933 times currently), that might be |
The optician icon is 3d, while the other icons look more 'flat'. I think that was also a design principle. I don't oppose the proposed icon, but it does stand out a bit. I wonder if there would be a way to create a icon without 3d-effect? If not, I'm find with going fo the proposed icon. |
I think that different icons for shop=alcohol and shop=wine would be an overkill, the same may be used for both. |
add icons for popular shop types
Thanks! |
Resolves #1415, #1412, #1408 and part of #1460.
alcohol
(distinction to beverages unclear #1407)electronics
furniture
(distinction to interior_design unclear #1406)(interior_decoration not considered for now)gift
jewelry, jewellery
mobile_phone
optician