Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add icons for popular shop types #1493

Merged
merged 1 commit into from
Apr 27, 2015

Conversation

nebulon42
Copy link
Contributor

Resolves #1415, #1412, #1408 and part of #1460.

alcohol (distinction to beverages unclear #1407)
alcohol

electronics
electronics

furniture (distinction to interior_design unclear #1406) (interior_decoration not considered for now)
furniture

gift
gift

jewelry, jewellery
jewelry

mobile_phone
mobile_phone

optician
optician

@matthijsmelissen
Copy link
Collaborator

For Jewelry, I also like an icon like this:

http://wiki.openstreetmap.org/wiki/File:Shop-jewelry.svg

Simpler than the ring, and the simpler the better on this scale, I guess.

@nebulon42
Copy link
Contributor Author

I had a try with the diamond, but the inverse version of what you linked here did not work out. I'm not sure regarding the linked version, it's rather noisy for me. I seriously considered the diamond, but then moved towards the ring in the end.

@matthijsmelissen
Copy link
Collaborator

Ok, good that you had a look at it at least!

@matkoniecz
Copy link
Contributor

alcohol (distinction to beverages unclear #1407)

Wiki has "shop=alcohol Shop selling alcoholic drinks" and "shop=beverages Shop focused on selling alcoholic and non-alcoholic beverages.".

@matkoniecz
Copy link
Contributor

Maybe shop=beverages may have something else rather than wine glass? Second bottle? Can?

@dieterdreist
Copy link

Am 21.04.2015 um 07:10 schrieb Mateusz Konieczny notifications@github.com:

alcohol (distinction to beverages unclear #1407)

Wiki has "shop=alcohol Shop selling alcoholic drinks" and "shop=beverages Shop focused on selling alcoholic and non-alcoholic beverages.".

it's mainly a cultural distinction, in countries with restricted sale of alcohol (e.g. USA, Iran) there are special alcohol shops, while in other countries you will get alcohol also in "normal" beverage shops, but also in these countries there will typically be shops that sell alcohol only, often just of some particular kind (typically high quality), like wine or whiskey.

@nebulon42
Copy link
Contributor Author

Ok, so beverages should be distinct. I will work on that later. Any further comments on these icons?

@imagico
Copy link
Collaborator

imagico commented Apr 24, 2015

optician, mobile_phone and gift seem fine to me.

furniture i would make the 'line' less prominent - right now it appears to be a two part object

jewelry seems too abstract to be easily recognizable - could also resemble some kind of doll/puppet or some technical stuff.

electronics seems ambiguous - could also mean a kind of public viewing location.

@dieterdreist
Copy link

2015-04-20 23:34 GMT+02:00 nebulon42 notifications@github.com:

alcohol (distinction to beverages unclear)
[image: alcohol]
https://cloud.githubusercontent.com/assets/3531092/7240957/8fa5b1f4-e7b5-11e4-8e7d-9788b4f90a45.png

There is also the tag shop=wine (used 1933 times currently), that might be
more suitable for those places specialized in wine, and your icon seems to
fit perfectly for wine.
Used not only in Europe: http://taginfo.osm.org/tags/shop=wine#map

@matthijsmelissen
Copy link
Collaborator

The optician icon is 3d, while the other icons look more 'flat'. I think that was also a design principle. I don't oppose the proposed icon, but it does stand out a bit. I wonder if there would be a way to create a icon without 3d-effect? If not, I'm find with going fo the proposed icon.

@matkoniecz
Copy link
Contributor

@dieterdreist

There is also the tag shop=wine (used 1933 times currently), that might be
more suitable for those places specialized in wine, and your icon seems to
fit perfectly for wine.

I think that different icons for shop=alcohol and shop=wine would be an overkill, the same may be used for both.

@nebulon42
Copy link
Contributor Author

I also would use the same icon for alcohol and wine shop. But that should be done afterwards if desirable.

Optician is 3D: true, but glasses without sidepieces look not that good e.g. optician-16 vs. optician
I'm also not satisfied with fake perspective here: optician-16

furniture: I'm not sure on the gap width but slightly more inclined towards the larger one. furniture 16 vs. furniture-16 (0.25px less wide)

For jewelry I have nothing else in store as the diamond did not work.

I think that TV might equal public viewing is a bit far fetched, but electronics shop is itself ambiguous so it's quite hard to settle onto a specific depiction.

matthijsmelissen added a commit that referenced this pull request Apr 27, 2015
add icons for popular shop types
@matthijsmelissen matthijsmelissen merged commit 06ca2ae into gravitystorm:master Apr 27, 2015
@matthijsmelissen
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add special rendering for shop=jewelry
5 participants