Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special rendering for shop=jewelry #1415

Closed
kocio-pl opened this issue Mar 18, 2015 · 10 comments · Fixed by #1493
Closed

Add special rendering for shop=jewelry #1415

kocio-pl opened this issue Mar 18, 2015 · 10 comments · Fixed by #1493

Comments

@kocio-pl
Copy link
Collaborator

We should start rendering shop=jewelry, probably with this icon from osmfr-cartocss fork:

https://github.com/cquest/osmfr-cartocss/blob/master/symbols/jewelry.svg

[It was proposed in meta-issue #1402]

@dieterdreist
Copy link

Am 18.03.2015 um 23:09 schrieb kocio-pl notifications@github.com:

We should start rendering shop=jewelry,

this should be shop=jewellery because all tags are in British English

@kocio-pl
Copy link
Collaborator Author

It's still stuck at the proposition level:

http://wiki.openstreetmap.org/wiki/Proposed_features/BE-Spelling_shop%3Djewelry

The usage is like 15996 vs 170, so:

  1. We can render both versions, since it's quite clear what are they and we're in state of transition.
  2. We can render only BE version to accelerate this process.
  3. We can render only current version, since it's approved and very popular.

I would pick 1 for now and maybe 2 when proposal is accepted.

@matkoniecz
Copy link
Contributor

Or we can wait with prominent rendering until situation is fixed - promoting better tagging scheme is OK but not in situation when it is losing 1 to 100.

@kocio-pl
Copy link
Collaborator Author

Sure. I said what I like the most, but for me any option is acceptable, since all have their strengths and weaknesses.

@pnorman
Copy link
Collaborator

pnorman commented Mar 19, 2015

this should be shop=jewellery because all tags are in British English

Yes - but what it should be is a tagging issue, while what it is is fairly clear.

@dieterdreist
Copy link

2015-03-20 0:20 GMT+01:00 Paul Norman notifications@github.com:

Yes - but what it should be is a tagging issue, while what it is is fairly
clear.

yes, but promoting an AE spelling variant by bringing it on the map will
a) set a precedent
b) carve this into stone
c) go against one of the fundamental, generic tagging rules, not just a
specific one

@matthijsmelissen
Copy link
Collaborator

a) set a precedent

We already do render railway=subway rather than UK English railway=metro or railway=underground. In UK English, a subway is a pedestrian underpass AFAIK.

Other common US English tags are highway=elevator (should be highway=lift), and sport=soccer (should be sport=football). I'm sure there will be more.

@nebulon42
Copy link
Contributor

jewellery-18.svg: jewellery-18

@jongleur1983
Copy link

What's missing for this to be done? A style patch only?
I don't think extensive tests would be required as it's basically the same as other shop icons that already exist.

@nebulon42
Copy link
Contributor

On my list. But as I wrote in #1402 (comment) I'm waiting for maintainers approvement as I don't want to end up with a lot of PRs that have no chance of getting merged.

nebulon42 added a commit to nebulon42/openstreetmap-carto that referenced this issue Apr 20, 2015
nebulon42 added a commit to nebulon42/openstreetmap-carto that referenced this issue Apr 20, 2015
nebulon42 added a commit to nebulon42/openstreetmap-carto that referenced this issue Apr 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants