Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for landuse=depot #3480

Closed
IgorEliezer opened this issue Oct 25, 2018 · 15 comments
Closed

Add rendering for landuse=depot #3480

IgorEliezer opened this issue Oct 25, 2018 · 15 comments

Comments

@IgorEliezer
Copy link

Expected behavior

"Depot" (landuse=depot) is an area for storage of buses, trucks, wagons, goods and material for logistics/transportation and public service companies, such as garbage trucks, school buses, police vehicles and urban maintenance equipment. Despite being rare, depot areas are usually fairly big.

Rendering landuse=depot would be a proper replacement for landuse=industrial + industrial=depot which seems to be a workaround to force render bus depots (example) and rail servicing yards (example) while nothing is being assembled or produced.

I suggest using the same pattern of landuse=garages, or a lighter version of landuse=commercial, with name and no icon.

It may conflict with landuse=railway, since the railway depot can overlap a railway land use (example).

Can be confused with:

  • landuse=garages: area for garages next to residential buildings.
  • landuse=industrial + industrial=depot: storage area of an industrial plant.
  • railway=yard: a node at the center of named freight railway yard, similar to railway=station.

Links:

Actual behavior

It's not being rendered at all.

Links and screenshots illustrating the problem

Examples:
https://www.openstreetmap.org/way/156582306
https://www.openstreetmap.org/way/281352494
https://www.openstreetmap.org/way/41646044
https://www.openstreetmap.org/way/568770554

@dieterdreist
Copy link

dieterdreist commented Oct 25, 2018 via email

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 25, 2018 via email

@kocio-pl kocio-pl added this to the New features milestone Oct 25, 2018
@mboeringa
Copy link

Rendering landuse=depot would be a proper replacement for landuse=industrial + industrial=depot which seems to be a workaround to force render bus depots (example) and rail servicing yards (example) while nothing is being assembled or produced.

This is not a "workaround", it is a sub-tag and refinement of the landuse=industrial, with a well documented page:

https://wiki.openstreetmap.org/wiki/Key:industrial

The basic question is: do we want to stimulate yet another tag in the landuse key itself, or is the use of the subtag to denote the specific function enough? I am not yet convinced it needs another tag. The argument that "nothing is produced" is weak. Industrial zones often have a wide variety of activity going on. And even "depots" can have serious maintenance going-on on e.g. trains, that borders on the brink of "production". Here in the Netherlands, they almost totally re-build trains during their mid-life update on the depot / maintenance yard...

@polarbearing
Copy link
Contributor

is the use of the subtag to denote the specific function enough?

yes. This tag was already rejected twice, #2989 and #1716.

@Adamant36
Copy link
Contributor

Adamant36 commented Oct 26, 2018

taghistory 1
Landuse=depot (1016 uses), industrial=depot (657 uses), depot=* (479 uses).

Whatever the case is about proper tagging, landuse=depot is clearly the favored tag. Although not by much. Also, it is mentioned on the main landuse=industrial under the see also section. Whereas, industrial=depot is not mentioned in useful combination section. Although it is mentioned on the industrial key page (plus it is mentioned in the industrial=depot tag page under see also. Both that and the numbers makes it seem as if landuse=depot is the preferred method. Or, there its not decided which one should be used. But its not clear going on all that at least that industrial=depot is the preferred tagging. Personally, I say its worth asking worth in the mailing list and consolidating the tags. Then rendering after. But doing nothing means it will just coming up. Personally, I think landuse=depot is the less complicated tag and makes more sense.

@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 26, 2018

Whatever the case is about proper tagging, landuse=depot is clearly the favored tag.

I may be highly biased here but I disagree. First of all usage of all this tags is really low, below 1000. And landuse=depot started earlier, if you take it into account usage may be considered nearly equal.

@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 26, 2018

rail servicing yards (example)

This is a clear landuse=railway, railway=depot. I have no idea why landuse=depot would be preferable.

It may conflict with landuse=railway, since the railway depot can overlap a railway land use (example).

Can you give an example of railway yard that is not landuse=railway?

@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 26, 2018

I propose to close it (again, see #2989 and #1716) as tag is rarely used and single tag for

  • container depot (landuse=commercial or landuse=industrial in some cases)
  • bus depot (clear landuse=commercial )
  • railway depot (clear landuse=railway )

just because name is similar makes little to no sense. And there should be a really good reason to start promoting a new landuse tag.

See also https://taginfo.openstreetmap.org/keys/landuse#values - this tag is less popular than landuse=yes, landuse=traffic_island, landuse=clearing, landuse=scrub, landuse=winter_sports etc.

Note that

Landuse=depot (1016 uses), industrial=depot (657 uses), depot=* (479 uses).

comparison is misleading for one fundamental reason - it is not considering many more depots that are mapped as part of standard landuses without depot=* tag like for example https://www.openstreetmap.org/way/475661134 https://www.openstreetmap.org/way/419426076 https://www.openstreetmap.org/way/101704683 https://www.openstreetmap.org/way/216723902

@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 26, 2018

And after looking at how this tag is used: landuse=depot is very often used for warehouses. And even after limiting to only industrial warehuses, and limiting again to this tagged as separate areas and again limiting to ones tagged with industrial=* tagging scheme - https://taginfo.openstreetmap.org/tags/industrial=warehouse is anyway more popular (1400 of industrial=warehouse alone).

Closing as 1000 usages is extremely low for landuse tag, this tag groups mutiple similarly named objects that describe different land use and it is othogonal to existing landuse tags and there is an existing tagging scheme that allows to avoid fragmenting landuse key further.

@Adamant36
Copy link
Contributor

@matkoniecz, can you bring up your various issues with the depot tags on the their respective wiki pages please? Then maybe things can get refined and it can be rendered later.

@matkoniecz
Copy link
Contributor

@Adamant36 Should be done for things mentioned in discussion above.

@Adamant36
Copy link
Contributor

@matkoniecz, I agree. So it would be nice if you did it. Since they are your points.

@matkoniecz
Copy link
Contributor

matkoniecz commented Oct 26, 2018

In this case "Should be done" was intended to mean "I made now edits necessary to document it, hopefully nothing was missed".

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 26, 2018 via email

@Adamant36
Copy link
Contributor

@matkoniecz, oh. I miss understood your meaning. Thanks for dealing with the wiki stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants