-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No icon for the world's tallest Ferris wheel #3550
Comments
There doesn't seem to be anything on the tourism=attraction wiki page for the attraction=* tag and it didn't come up in search. Do you know its status or have any other information on it? It looks like it has 23,207 uses. So it might be worth rendering icons for, but it would probably at least need a wiki page first. Currently issue #3545 is discussing removing name rendering from things tagged as tourism=attraction. That might be an issue in light of this or at least worth considering. I think you'll be in an even worse place if the ferris wheel doesn't even have its name rendered anymore. So it might be worth sharing your opinion on name rendering there. outside of that, I could have swore there was another tag besides attraction=* for things found in theme parks or that it at least had its own page, but I can't seem to find either. So maybe I'm wrong. |
All I know is we see something like
https://wiki.openstreetmap.org/wiki/File:Bigwheel.png
in the (iD) editor, but then it doesn't make it into the final product.
I mean these things can be seen several counties away, which should earn
them at least an icon.
|
Attraction=* is not actually a subkey for tourism=attraction, rather it is
meant to tag various rides, animals etc in Theme Parks, Zoos and similar
places.
Since most of these are smaller features within a theme park or zoo,
normally they would not be rendered very prominently. I wonder if there is
a better tag for the huge sight-seeing Ferris wheels in big cities?
|
Makes sense. I agree with you that there could be a better tag. As far as I knew huge ferris wheels like the one London aren't actually in themes parks anyway. |
Looks like sane object to render, given estimated low number of them and relatively big importance, we have enough of them already in my opinion (318) and the numbers are growing fast, it is also documented: https://taginfo.openstreetmap.org/tags/attraction=big_wheel |
Icon proposal: Gist link: https://gist.github.com/Tomasz-W/033be1e9c86b6cf814039f250155655c |
What color should we use? |
Amenity brown? They are points of interest where you can pay for a service
(riding on the observation wheel to see the sights).
But man-made icon gray could work too, if we think they are mainly
orientation points.
|
man-made was my first thought also, but it would be more within things like Zoo or Museum, thus amenity-brown is more logical. |
I prefer the second logo from above, it's a bit bolder, how does it look in 14px size? Brown would seem to make more sense, at least for the big_wheel variety. I can take this if there's agreement? |
@Tomasz-W 's icons are already 14x14. As far as color, we do have a category for tourist attractions. Seems a more logical fit than amenity or man made. I do not believe we have ever had an attraction colored icon, but there's a first time for everything. Zoos have recently moved to this color. |
Do we want an icon for every 'attraction=big_wheel', or just for those with 'tourism=attraction'? I'll post a couple of examples presently. |
Do we want an icon for every 'attraction=big_wheel', or just for those
with 'tourism=attraction'?
The key “attraction” is not imported as a polygon, so it cannot yet be used
as a stand-alone key for the feature (though we could change this in >6
months when the database is next reloaded on the osm servers)
So for now we need to consider if “attraction=“ requires a
tourism=attraction tag, according to the wiki and usual practice in the
database.
|
The wiki entry for attraction=* claims that it is not a subkey of tourism=attraction
Tourism=attraction has 175k of which 11k have attraction=* entered, there are 25k total attraction=* tags. I'm minded to render everything with attraction=big_wheel as above, unless there are reasonable objections? |
We can’t render any closed ways (areas) tagged “attraction=“ alone at this
time, so we will probably need to wait till the next database reload, when
this can be updated. This may be in 6 months to a year.
|
The feature on top with name=Wheelm of Liverpool is tagged
tourism=attraction; tourism tags are imported as polygons (eg tourism=hotel.
The second with name Echo Wheel if Liverpool is tagged building=yes, so
this will also be imported as a polygon.
|
Now a year later commit da1910/openstreetmap-carto somehow is still not being rendered anywhere. |
Again a very demanding tone from you :-( Nitpick: 20.2.2020 is still in the future :) But more important in a volonteer project is the work which has been done: The next release will probably includes the required schema changes. Ref #4031 |
@jidanni, the commit you are talking about (da1910@01476ae) is not in this repository, rather it was done by @da1910 in their own repository. So far there is no PR submitted to render this feature. |
I can put in a pull request for the changes, but I don't know how likely it is that it will be approved, it will also likely need to be changed when the schema changes happen, so I suspect the first response will be to wait until then. |
We did not end up including any |
Taiwan's tallest Ferris wheel is indicated by just a child's see-saw.
https://www.openstreetmap.org/node/5513773274
Taipei's Ferris wheel isn't even indicated,
https://www.openstreetmap.org/node/5121602758
No icon for the world's tallest Ferris wheel either,
https://www.openstreetmap.org/node/3521729497
The text was updated successfully, but these errors were encountered: