Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No icon for the world's tallest Ferris wheel #3550

Open
jidanni opened this issue Dec 6, 2018 · 23 comments
Open

No icon for the world's tallest Ferris wheel #3550

jidanni opened this issue Dec 6, 2018 · 23 comments
Labels
new features Requests to render new features POI

Comments

@jidanni
Copy link

jidanni commented Dec 6, 2018

Taiwan's tallest Ferris wheel is indicated by just a child's see-saw.
https://www.openstreetmap.org/node/5513773274

Taipei's Ferris wheel isn't even indicated,
https://www.openstreetmap.org/node/5121602758

No icon for the world's tallest Ferris wheel either,
https://www.openstreetmap.org/node/3521729497

@Adamant36
Copy link
Contributor

Adamant36 commented Dec 6, 2018

There doesn't seem to be anything on the tourism=attraction wiki page for the attraction=* tag and it didn't come up in search. Do you know its status or have any other information on it? It looks like it has 23,207 uses. So it might be worth rendering icons for, but it would probably at least need a wiki page first.

Currently issue #3545 is discussing removing name rendering from things tagged as tourism=attraction. That might be an issue in light of this or at least worth considering. I think you'll be in an even worse place if the ferris wheel doesn't even have its name rendered anymore. So it might be worth sharing your opinion on name rendering there.

outside of that, I could have swore there was another tag besides attraction=* for things found in theme parks or that it at least had its own page, but I can't seem to find either. So maybe I'm wrong.

@jidanni
Copy link
Author

jidanni commented Dec 6, 2018 via email

@jeisenbe
Copy link
Collaborator

jeisenbe commented Dec 6, 2018 via email

@Adamant36
Copy link
Contributor

Makes sense. I agree with you that there could be a better tag. As far as I knew huge ferris wheels like the one London aren't actually in themes parks anyway.

@kocio-pl kocio-pl added the POI label Dec 6, 2018
@kocio-pl kocio-pl added this to the New features milestone Dec 6, 2018
@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 6, 2018

Looks like sane object to render, given estimated low number of them and relatively big importance, we have enough of them already in my opinion (318) and the numbers are growing fast, it is also documented:

https://taginfo.openstreetmap.org/tags/attraction=big_wheel
https://wiki.openstreetmap.org/wiki/Key:attraction

taghistory 31

@Tomasz-W
Copy link

Tomasz-W commented Dec 6, 2018

Icon proposal:

  • attraction big_wheel (v1)
  • attraction big_wheel (v2)

Gist link: https://gist.github.com/Tomasz-W/033be1e9c86b6cf814039f250155655c

@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 7, 2018

What color should we use?

@jeisenbe
Copy link
Collaborator

jeisenbe commented Dec 7, 2018 via email

@polarbearing
Copy link
Contributor

man-made was my first thought also, but it would be more within things like Zoo or Museum, thus amenity-brown is more logical.

@da1910
Copy link

da1910 commented Feb 5, 2019

I prefer the second logo from above, it's a bit bolder, how does it look in 14px size? Brown would seem to make more sense, at least for the big_wheel variety. I can take this if there's agreement?

@meased
Copy link
Contributor

meased commented Feb 5, 2019

how does it look in 14px size

@Tomasz-W 's icons are already 14x14.

As far as color, we do have a category for tourist attractions. Seems a more logical fit than amenity or man made. I do not believe we have ever had an attraction colored icon, but there's a first time for everything. Zoos have recently moved to this color.

@da1910
Copy link

da1910 commented Feb 15, 2019

Do we want an icon for every 'attraction=big_wheel', or just for those with 'tourism=attraction'? I'll post a couple of examples presently.

@da1910
Copy link

da1910 commented Feb 15, 2019

Here's some tests, currently drawing the icon at z15+ and the name at z17+, but moving that is easily done. Currently the liverpool wheel has two names as it's separately tagged tourism=attraction and as attraction=big_wheel.
screenshot from 2019-02-15 16-32-44
screenshot from 2019-02-15 16-32-52
screenshot from 2019-02-15 16-50-36

@jeisenbe
Copy link
Collaborator

jeisenbe commented Feb 15, 2019 via email

@da1910
Copy link

da1910 commented Feb 19, 2019

The wiki entry for attraction=* claims that it is not a subkey of tourism=attraction

This is no subkey of tourism=attraction since the attractions are usually part of bigger venture.

Tourism=attraction has 175k of which 11k have attraction=* entered, there are 25k total attraction=* tags. I'm minded to render everything with attraction=big_wheel as above, unless there are reasonable objections?

@jeisenbe
Copy link
Collaborator

jeisenbe commented Feb 19, 2019 via email

@da1910
Copy link

da1910 commented Feb 20, 2019

That's odd, as if that's the case then I shouldn't be seeing the icon in the liverpool example above. It's tagged as an attraction=big_wheel but no tourism tag and a separate building with tourism=attraction but no attraction tag. I don't know what's going on here in that case.
screenshot from 2019-02-20 13-48-50
screenshot from 2019-02-20 13-49-02

da1910 pushed a commit to da1910/openstreetmap-carto that referenced this issue Feb 20, 2019
@jeisenbe
Copy link
Collaborator

jeisenbe commented Feb 20, 2019 via email

@jeisenbe jeisenbe added the new features Requests to render new features label Sep 4, 2019
@jidanni
Copy link
Author

jidanni commented Feb 14, 2020

This may be in 6 months to a year.

Now a year later commit da1910/openstreetmap-carto somehow is still not being rendered anywhere.

@HolgerJeromin
Copy link
Contributor

HolgerJeromin commented Feb 15, 2020

Now a year later commit da1910/openstreetmap-carto somehow is still not being rendered anywhere.

Again a very demanding tone from you :-(

Nitpick: 20.2.2020 is still in the future :)

But more important in a volonteer project is the work which has been done: The next release will probably includes the required schema changes. Ref #4031

@jeisenbe
Copy link
Collaborator

@jidanni, the commit you are talking about (da1910@01476ae) is not in this repository, rather it was done by @da1910 in their own repository.

So far there is no PR submitted to render this feature.

@da1910
Copy link

da1910 commented Feb 15, 2020

I can put in a pull request for the changes, but I don't know how likely it is that it will be approved, it will also likely need to be changed when the schema changes happen, so I suspect the first response will be to wait until then.
On the plus side, having several vocal supporters of the addition is a good sign!

@jeisenbe
Copy link
Collaborator

We did not end up including any attraction=* features in the schema changes, so any that are mapped as closed ways to represent areas would need to wait for the next database reload, including this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new features Requests to render new features POI
Projects
None yet
Development

No branches or pull requests

9 participants