Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beach pattern doesn't render in some areas #3554

Closed
Adamant36 opened this issue Dec 8, 2018 · 7 comments
Closed

Beach pattern doesn't render in some areas #3554

Adamant36 opened this issue Dec 8, 2018 · 7 comments

Comments

@Adamant36
Copy link
Contributor

Adamant36 commented Dec 8, 2018

beaches should render with a sand pattern.

some beaches aren't rendering with a sand pattern.

https://www.openstreetmap.org/#map=17/37.77149/-122.51049 (location 1)
beach location 1

https://www.openstreetmap.org/#map=17/37.80577/-122.46216 (location 2)
beach location 2

I don't what the deal is. The tagging doesn't seem to be any different then the other beaches in the area. Which render properly. If it was a tagging issue though id think it wouldn't render at all, not just leave pattern out. It might be something to do with the latest version of the map. I'm pretty sure I had looked around that area before it came out and I didn't notice the problem back then.

(after looking around more, it seems to be a common problem along the California coast. While some beaches render fine. A lot of them don't)

@kocio-pl kocio-pl added this to the Bugs and improvements milestone Dec 8, 2018
@meased
Copy link
Contributor

meased commented Dec 9, 2018

The sand pattern is only rendered when tagged with surface=sand. This is consistent with other beaches in the area.

@Adamant36
Copy link
Contributor Author

Adamant36 commented Dec 9, 2018

Not according to this in the landcover file

 [natural = 'beach'],
    [natural = 'shoal'] {
      [surface = 'sand'] {
        polygon-pattern-file: url('symbols/beach.png');
        polygon-pattern-alignment: global;

Otherwise, it should be called sand.png instead of beach.png

Also, see the wiki. Which shows pattern rendering for natural=beach. https://wiki.openstreetmap.org/wiki/Tag:natural%3Dbeach

@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 9, 2018

As far as I know @meased is right. The name could be improved (maybe grain.png).

Anyway it could be good if you provide links to both beach rendering examples.

@Adamant36
Copy link
Contributor Author

How come it has the code to be rendered with a pattern in the landcover file and also a picture of it rendered with the pattern on the wiki then?

There's links to after examples in my original message. I don't have any before renderings unfortunately. Maybe I just spaced it and it was never rendered with a pattern, but I'm sure I would have noticed it and the evidence in the code and on the wiki makes me think otherwise. Unless the code and wiki is wrong. Which is possible.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Dec 9, 2018 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Dec 9, 2018

Some wiki review might be good, I believe. Most probably this is not a rendering problem.

@Adamant36
Copy link
Contributor Author

It seems there's a PR from 2015 about rendering beaches without patterns #1990. My bad. I'm not crazy, I swear. I guess someone should update the wiki at least.

@jeisenbe, I know not all beaches are sandy, but why render it in yellow then? Since mud etc isn't yellow. Seems like it should be a neutral color and rely on the patterns instead, if it can be any color in real life.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants