Add rendering for leisure=water_park

[PauloCarvalhoRJ]

Map: http://www.openstreetmap.org/#map=17/-22.98075/-43.48637

To the south of the parking lot there is a water park, represented by a polygon (id=263566033) with leisure=water_park and name=Rio Water Planet. There is also a node (id=2692030832) with the same tags. None of them are being rendered in OSM slippy map. If you enable "Map data" you can see its outline.

I've already checked for cache issues, etc. The parking lot and the neighbouring club belong to the same changeset and both are being rendered, thus this is not a cache issue.

Thanks.

[PauloCarvalhoRJ]

Anyone?

[mrwojo]

We can add this to the theme park layer.

• TagInfo: leisure=water_park
• TagInfo: tourism=theme_park

[PauloCarvalhoRJ]

No solution to this yet? Is it complicated?

[gravitystorm]

@PauloCarvalhoRJ patience, please - it's not a high priority and there are literally hundreds of other things to work on too.

[PauloCarvalhoRJ]

I do have patience (13 days, 2 posts). Furthermore I can do it myself if you point out how.

[Rovastar]

Patience is relative. On in CartoCSS 13 days is not long at all.

Fell free to install what is needed for cartoCSS and produce a pull request.

[pnorman]

We're currently in the easier to wrangle stage of development where we're cleaning up the style still. New feature requests are currently not a development priority. A pull request won't significantly change matters.

[matthijsmelissen]

See also https://trac.openstreetmap.org/ticket/3600

[daganzdaanda]

Hi, I just want to vote this up, too ;) It's getting summer, and people are starting to go to the swimming pools.
A water_park could maybe render in a lighter version of the sport_centre green. I guess many water_parks will have details like swimming pools, meadows, footways, buildings, parking, waterslides, beachvolleyball or other pitches. So it should look good also with these details.

[kaldari]

I would be happy to fix this and submit a pull request if someone could point me in the right direction.

[matthijsmelissen]

@kaldari Which operating system do you use?

[kaldari]

MacOS

[matthijsmelissen]

Did anyone successfully set Tilemill up in MacOS? I'm running Ubuntu myself, and most tutorials I have seen are also written for Ubuntu.

[PauloCarvalhoRJ]

@math1985 MacOS is a Posix system. If the tutorials are composed by shell commands, then they should work on MacOS too given all software dependencies are installed in your system.

[matthijsmelissen]

The dependencies are the problem, it relies on apt-get and the Ubuntu package repositories.

[pnorman]

Did anyone successfully set Tilemill up in MacOS? I'm running Ubuntu myself, and most tutorials I have seen are also written for Ubuntu.

https://gist.github.com/springmeyer/2164897 might help.

[kaldari]

Apparently this bug was first raised 4 years ago (https://trac.openstreetmap.org/ticket/3101)! I guess I shouldn't hold my breathe then.

[matthijsmelissen]

Development has been on hold for some years, because the old stylesheets were too hard to maintain. @gravitystorm has converted the stylesheets to cartocss during the last 1,5 year, and now they are a lot easier to modify. A lot of things have been solved recently (only on Github 359 resolved issues in the last 1,5 year). However, we still have a huge backlog, and we can always use more volunteers to handle the issues that are left. On trac, we are down from 400 to 159 issues (which should be 0 soon), and on Github, we also still have 267 issues left to solve.

[kaldari]

I made a pull request, complete with a new water park icon. I'm still not going to hold my breathe though ;)

[PauloCarvalhoRJ]

Thanks, kaldari, I'm eager to see the results!

All the best,
Paulo

[nighto]

Thanks @kaldari!

Just as a curiosity note (no pressure!), but because I'm also interested in this matter: how much time (aproximately) would it take to these changes appear on the main website? Days, weeks?

Thanks everyone for the hard work in this project.

[dieterdreist]

2014-06-18 16:43 GMT+02:00 Arlindo Pereira notifications@github.com:

Just as a curiosity note (no pressure!), but because I'm also interested
in this matter: how much time (aproximately) would it take to these changes
appear on the main website? Days, weeks?

when the style sheet modification goes live you can also force manually the
rerender of a given tile (add /dirty to the url of the tile and the whole
metatile (8x8) will get rerendered).

[nighto]

@dieterdreist Of course. But my question was about when should I expect that the style sheet modification goes live.

[matthijsmelissen]

The process is that @kaldari needs to correct his pull request (no idea how long he will take), @gravitystorm needs to approve it and roll out the next version (normally every couple of weeks, but might get delayed if he considers it a feature request), Tom Hughes needs to upgrade the carto version on the rendering servers (usually within one or two days), and the rendering servers need to re-render (couple of hours).

[Klumbumbus]

I thought he did correct the pull request with #639.

[matthijsmelissen]

Sorry I missed that, you're right.

[nighto]

That's what I wanted to know, @math1985. Thanks for clarifiying the process!

Once again, thanks to @kaldari, @gravitystorm and all involved in this hard work.

[kaldari]

Well the patch was finished months ago, but I can't seem to get any response from the project maintainer (gravitystorm). I tried pinging him on the pull request and even sent him an email, but no response so far.

[pnorman]

As noted in the roadmap, new features are not currently a priority - having a patch doesn't eliminate the review required when merging a PR.

[kaldari]

pnorman: Is there anything else I can do to help the process along or should I just wait now?

[matthijsmelissen]

Fixed by #725.