-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering for public_transport=platform #435
Comments
public_transport=stop_position is used over 200,000 times. http://taginfo.openstreetmap.org/keys/public_transport#values |
In the West Midlands of UK we have been mapping bus stops using highway=bus_stop at the location of the shelter/sign (i.e. on the pavement). The equivalent tag in the Public Transport schema would be public_transport=platform. We need to be a bit careful about what we render. The worst case solution is that we end up rendering bus stops in 2 places - on the road way and where the shelter/sign/platform is. This is a Bad Idea as it will confuse people and may lead to some folks removing one instance as they may see it as duplication. Some stats:
From Taginfo Global:
I would love to be able to say that we can solve this problem by having different rendering rules in different countries (depending on the dominant tag use), but this would be a nightmare to code and maintain. Worse still it would be a short term sticking plaster solution that would lead to entrenched fragmentation in OpenStreetMap. |
And what is preventing users from doing this right now? In fact I have tagged several of my first Bus stops exactly like that, because ID shows a nice icon on the way when you put a bus_stop on it. http://taginfo.openstreetmap.org/tags/public_transport=stop_position#combinations As you can see 100000 bus_stops are mapped on a stop position. Considering that the platform tag has been used as much it's pretty save to say that most of those stop positions (and bus_stops on them) are on the road. So this is already a problem today. There reason you don't see it is probable because people mapping just remove one. So what about rendering a this blue dot like on tram_stop(?) on public_transport=stop_position and/or using the icon on the public_transport=platform tag? Then you don't know what to render, right? Bus or tram? So could there be a general icon like it is used in Germany? http://commons.wikimedia.org/wiki/File:Zeichen_224.svg (not suggesting to use that one). Wouldn't that be a good idea in general to have such an icon for combined bus&tram stops? Should we use a tag like public_transport:platform=bus? |
Nothing is preventing people from deleting things right now, but as you have discovered, things that are rendered draw a lot more attention (from both mappers and people who just view the Mapnik render). Unfortunately I struggled to follow the rest of you're comment. But my point still stands. Take a look at this area: http://www.openstreetmap.org/#map=19/50.93487/6.96162 It already has a mix of where the bus icon is rendered - some on the road, some beside the road. The concern is that we end up rendering some bus stops on both. I would suggest that a good first step would be to promote consistent use of the highway=bus_stop tag (for tagging the bus shelter/sign) and then you could ask for public_transport=platform with bus=yes to be rendered the same as highway=bus_stop. Although I expect that you'd feel differently about this. (Note: My comment is all about buses. As the public_transport tag is for all forms of transport, then you'd have to consider each one separately as the rendering implications of each may be different). |
My point is simply how many bus stops do we see with two icons for the exact same stop? Pretty much zero. Why? Because people see it on the map and fix it. That's why I don't see why it would be any different if a public platform get rendered the same way, too.
But how is that going to happen? There are over 100k that are tagged wrong as they are on a stop position and probably a lot more without such a tag.
That part is fine. I mean then that bus tag would have to be put there in addition because right now it is supposed to go into the stop position. |
Since 25th April 2008 the (English language) highway=bus_stop wiki page has clearly stated that the highway=bus_stop tag should be mapped beside the road. As such the expectation is that the bus stop is rendered beside the road. This request would change this convention to render bus stops as part of the road's way. A change that is bound to lead to duplication of the rendered icon and confusion amongst mappers and map users. P.s. I'm not sure when the public_transport schema came about (the wiki suggests later), but really it doesn't matter. What matters is that a tagging issue does not become a rendering issue. This is not a simple fix and regrettably shows the problem of new tagging schemas that are not backwards compatible. Hopefully we can learn from this and make better decisions in the future as it is a great shame that we have this mess. |
For me that is everything, but clear. It even repeats it.
The problem is that it does. Your best tagging scheme is not going to be used if it does not show up on the map, but the old alternative does.
But that isn't because public=transport is bad, that's because highway=bus_stop is a mess and there was never an agreement how to use it exactly. As you said before if they were all on the side of the road you could apply the same icon on public_transport=platform + bus=yes right away. |
+1, I suggest we do this and fix problems then in the map |
I don't have a problem if that's how it is, but until Rob changed the wiki yesterday it stated twice (see my quote above) that the tag is sometimes used on the way and did not say that is a wrong usage. What I would have expected if there is a 6 year old agreement is that it is worded like it is now. Also if that is the agreement, then I guess there should be no problem to apply the same icon on |
I did change the wiki page yesterday, yes. Why? Because I looked through I'm glad that we are coming to the same conclusion - encourage the proper For other transport modes, stop position may be ok. For buses use platform. On 2 Apr 2014 09:31, "AndiG88" notifications@github.com wrote: I don't have a problem if that's how it is, but until Rob changed the wiki Also if that is the agreement, then I guess there should be no problem to Reply to this email directly or view it on GitHub.[image] |
"Also if that is the agreement, then I guess there should be no problem to apply the same icon on public_transport=platform+ bus=yes as that exactly matches?" Irrespective of the validity of the bus stop discussion I am rolling out my stock answer here if these tags are not stored in our Carto database they will unlikely to be added to the map. We are not making schema changes to the database yet to accommodate this. And to my knowledge we do not have a field for "bus" or probably "public_transport" hence there this will not be done for a while even if it was a valid suggestion. |
2014-04-02 15:39 GMT+02:00 Rovastar notifications@github.com:
maybe this was already mentioned and/or replied to, sorry if so, what about |
The rendering performance penalty for The rendering performance penalty for the mapnik german .style + hstore is substantial, at 4.7% (unpublished results with views). However, this misses the point for two reasons.
|
2014-04-03 8:27 GMT+02:00 Paul Norman notifications@github.com: Paul, it is clear that hstore would mean a significant schema change We have public_transporthttps://github.com/gravitystorm/openstreetmap-carto/blob/master/openstreetmap-carto.style#L126in but as I understand we don't have "bus" currently so we don't know whether |
Is there any key where you could put the information what kind of bus stop that is? Otherwise what about using a general icon? In Germany for example all stops just have an H, is there some kind of international icon for that? |
If suddenly we had a load of H's displayed on the map I would feel left out not owning a helicopter. ;-) @pnorman I should have checked and yes we do have public transport. It was more about I knew we didn't have bus = key which we would need to render this correctly like dieterdreit pointed out |
For what it's worth, I'm 👎 on rendering |
So... have you ever talked with the JOSM developers about this? |
the complete mapping would be both, platform and stop position with key public_transport while the stop position with highway bus stop is implicit (but mapping isn't completely consistent neither there)
you could do this similar to highway shields but with a lot of spacing to avoid duplicates?
IMHO the middle of the station is similar to the middle of a bus stop, no inconsistency
+1 |
sorry, what I meant was the node where the
Thank you this worked. Some examples:
Yes, but with this approach we do render the bus stop symbols on the platform and not in the middle of the bus stop, while we render the railway and tram stop symbols in the middle of the station and not on the platforms. If we wanted to be consistent with |
public_transport tag is available in the database, but bus tag and others tags specifying type of stop_position are not. So currently it is impossible to check whatever element is a bus stop. To replace current style, without losing ability do display bus/tram/etc stops in a different ways database change is necessary |
Re-added milestone. |
and
They kept only for that "mapper feedback loop". And data consumers use public_transport=* because they can get meaningful data (4 separate tags), not randomly placed highway=bus_stop or highway=platform which pretend to cover 3-4 objects at once. If all software functions, nobody cares about tagging. And no, this isn't "a non-standard tag" but one of 4 ways to mark a PT http://wiki.openstreetmap.org/wiki/Proposed_features/Public_Transport#Stop (s) Which was approved: 83 approve the proposal, 6 oppose the proposal. If you want 83 people to respect your opinion, don't neglect fact that this is hugely supported tag/proposal within OSM community. And if @AndiG88 and @gravitystorm have a short memory on approved tags (not random tags like highway=platform or highway=bus_stop that were defined despite agreement on highway=*): a highway=* key reserved for "highway=* should be changed to importance for the road grid (hierarchical position in the interconnecting network) instead of physical attributes. " (https://wiki.openstreetmap.org/wiki/Proposed_features/Highway_key_voting_importance) |
Please rename issue to public_transport=platform, per author request:
|
Creator of an issue may edit title of the issue. |
Can anyone supply link with documentation why Neither https://wiki.openstreetmap.org/wiki/Tag:public_transport%3Dplatform nor https://wiki.openstreetmap.org/w/index.php?oldid=625726 nor https://wiki.openstreetmap.org/wiki/Key:public_transport is explaining this. I assume that there is some reason for that (this tagging is quite widely used) but it seems to not be documented anywhere and reasons for that should be quite strong to justify deprecating tags used millions of times and to introduce more complicated tagging. I found https://wiki.openstreetmap.org/w/index.php?oldid=625726#Main_Problem_with_the_existing_Schema but is it entire reason for new scheme? Given that it adds other new significant problems, that at least in my opinion are worse than what is listed there, I am not convinced that it is a good idea to support it. Note that it makes no sense to render both And assuming that EDIT 2019-10-22: According to the proposal itself - standard tags like Note
in the proposal - https://wiki.openstreetmap.org/w/index.php?oldid=625726#What_this_Proposal_does_not_cover |
The problem is it is already fragmented and after many years it continues to be so. I am not fully up to speed with public transport mapping (I no longer do any as I find it too complicated and don't have the time to read it all), but if mappers who have previously spent many hours using PTv2 have doubts then it seems far from clear cut that this is the way to go. https://www.openstreetmap.org/user/Polyglot/diary/44333 There is also the Ptv3 proposal from @Zverik : p.s. since my post 1 April 2014 the number of highway=bus_stop tags has increased by 1 million. It certainly doesn't feel like something we should stop rendering. |
iD now has a new validation rule that adds a highway=footway to a public_transport=platform way. While this is not totally wrong, the public_transport tag already tells us that its primary function is a platform, it makes non-compatible renderers like osm-carto render a platform as a footway. It would be better when osm-carto knows that a way like this one, is a platform and doesn't need an extra highway=platform for compatibility. |
I've just looked into this issue, and the comment above is correct: #435 (comment) It is not at all standard to use Some mappers are using the tag in this way. Taginfo shows that only 59% of There's also 6% of public_transport=platform combined with So it appears that the best way to specify a bus stop at the side of a road, as opposed to "any kind of place to wait for a public transportation vehicle", is to use The situation is the same for Since this is the case, I believe @pnorman is correct: this issue should be closed, and we should continue to rely on the current tags to render bus stops, train platforms and the rest. This may even have been the original intention of the public_transport proposal, since there was no other way to specify the mode or vehicle at a public_transport=platform other than using the pre-existing tags? |
Actually there are two issues here, that can be solved at once or separately: platform as a node and platform as a way. The reaction above is mostly about the former. The latter is however becoming the biggest issue. public_transport=platform as a node In my opinion at least both tagging schemes should be rendered, so the compatibility tag public_transport=platform as a way Not rendering this is becoming more and more an issue. The iD editor is now adding The latter issue could be easily solved, even without solving the former issue. In this case |
Are you sure? Afaik this iD bug/misfeature was fixed.
Incorrect data can be shown as incorrect. This style is intended as feedback to mappers so this is OK.
It seems disputable to me, see comment about yours. Neither PTv2 proposal nor usage supports this. And still nobody answered #435 (comment) question
|
I would say that this is how we could get out of ambiguity of what a "bus stop" really means without unexpected dropping common tagging. |
Closing per https://wiki.openstreetmap.org/w/index.php?oldid=625726#What_this_Proposal_does_not_cover
ongoing dominance of standard and simple tagging (see #435 (comment) ) and lack of documentation why significantly more complex and confusing tagging scheme would be wanted (see #435 (comment) ). I am especially confused why this proposal was created and supported in the first place given that stated intention was to duplicate existing tagging without intention of replacing it. Overall simple tagging ( |
Just above the section you cited you can find why that proposal was created. As to why this proposal did not call for replacement of PTv1, I can only guess that was in order to have a gradual deprecation later while keeping compatibility for the time being.
It is older, global transitions are not that quick. 1.5M |
Sorry. Not sure why I have not mentioned it. But note that mentioned problems are not really relevant to explaining why new proposal is desirable.
This proposal failed to solve it - as old tags are not replaced anyway
Not sure why this extra preprocessing step should be done manually, instead of automatically. It could be understood if that extra processing was impossible, but it is not such case
Not sure why it is considered as a problem, tagging both is a pointless duplication.
This part maybe makes sense. It is hard to say as I never tagged or really maintained such info. But it is not relevant to other parts. I still claim that documentation why significantly more complex and confusing tagging scheme would be wanted is missing. I am still confused why this proposal was created and supported in the first place given that stated intention was to duplicate existing tagging without intention of replacing it. I still think that simple tagging (highway=bus_stop type) is preferable over more complex that makes everything more complicated (simplest bus stop tagged three times in two different places). Enormous effort went into discussing and using it, without any clear analysis/documentation why additional complexity is worth negative effects. I hope that bias here to not change my original opinion is not significant. |
Interpretation 1 - strict following proposal
So rendering
Maybe. But AFAIK there was never a clear support for such deprecation. Interpretation 2 -
Note https://wiki.openstreetmap.org/w/index.php?title=Proposed_features/Public_Transport&oldid=625726#Compatibility_with_well_known_tags - But in use of Looking at https://taghistory.raifer.tech/ it has about 2 000 k uses for It is now 2 500 k https://taginfo.openstreetmap.org/search?q=highway%3Dbus_stop vs 1 587 k for alternative https://taginfo.openstreetmap.org/tags/public_transport=platform But only 989 k It is possible that BTW, https://wiki.openstreetmap.org/w/index.php?title=Proposed_features/Public_Transport&oldid=625726#Compatibility_with_well_known_tags makes clear that to mark something as bus stop according to this proposal one must use |
Edit: Okay maybe rather use it on public_transport=platform
Use the same icon as highway=bus_stop
(if you want to do more use different ones depending on bus/tram=yes/no)
It would be great if you could support the "new" public transport schema, I think one of the main reason people don't use it, is because it does not show up on the map.
http://wiki.openstreetmap.org/wiki/Key:public_transport
http://wiki.openstreetmap.org/wiki/Proposed_features/Public_Transport
The text was updated successfully, but these errors were encountered: