-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render brand if name isn't present on amenity=fuel, shop=supermarket etc #698
Comments
Agree, it would stimulate correct tagging. |
With displaying brand key or with adding name equal to brand? |
https://trac.openstreetmap.org/ticket/3042 suggests doing this also with supermarkets (it mentions operator key, but brand is more suitable) |
2014-07-03 14:06 GMT+02:00 Mateusz Konieczny notifications@github.com:
+1 for brand. brand should be the name of the brand (e.g. Shell, ESSO, BP, Could also be done for supermarkets and car dealers (and probably more, |
amenity=fuel what else? maybe just allow any shop to use brand tag? |
Is the proposal to render brand, or a combination? Maybe even brand on low zoom (if name is absent), and something like "name (brand)" on high zoom? Does not seem really satisfactory to me. |
The proposal is to render brand tag iff name tag is absent. |
Hotels might be either best known by the brand name, or by the hotel name, or by the combination. Especially for hotels that are (much) older than the brand they currently belong to, the hotel name is more important. For example in Amsterdam, 'Amstel hotel' is well-known, and most don't know the brand is InterContinental. |
In this case only hotel name would be rendered. |
Rendering “brand” instead of “name” if “name” is absent would be a good idea! I like this. |
Just a thought: Sometimes the value of the name tag will duplicate the brand. Imaging a fueling station in Myvillage: brand=Shell, name=Shell station Myvillage. I think this is not seldom in the database (for example for Germany). In this case, rendering “Shell station Myvillage (Shell)” would duplicate the information. On the other hand, there will be situations (for example a hotel which belongs to a brand but has a name which doensn’t contain the brand) where you have the opposite, and adding “(brand)” would be a gain of information. But how can we detect automatically when it’s useful to add the brand and when not? |
It's reasonably easy to detect if the brand appears within the name. Would that work? |
I am surprised how clean the brand key is. operator is much more chaotic ("DB Netz" next to "DB Netz AG"). |
I would not consider trying to detect the brand name in the name tag. Also to expand on this in the future for 3.0 (sometimes called the "distant future") can be extended for operators too for things like stadiums, etc. |
This also makes sense for amenity=bank, see #698. |
Yes, it makes sense for |
Exactly the same here in Poland: ""Euronet" vs "Euronet Sp. z o.o.". Brand is the most visible and important thing for the user/customer (this is the main function of brands) and sometimes brands are being sold to another operator as they are - probably to use well known and trusted label. |
Often in the U.S., a gas station or fast food restaurant may have the city name or location number included in The downside to this fallback is that labels become a bit less predictable. |
That is some of my opinion, but I feel the purpose of this map is rather to promote correct tagging than ideal way to display things. I am working with a Brazilian specific rendering style, where we propose to promote brand of certain gas stations, banks, fast food chains etc. i.e. letting HSBC banks be displayed on the map with a HSBC logo instead of a generic bank symbol. That kind of things are for special interest maps, but in your case it would be rather more friendly if the displayed |
I'm totally for displaying brand=* if name=* is absent. |
I've gone back and forth on this, but after much thought, I'm against it. The biggest reason is that it adds a complication to what a mapper may reasonably expect to be simply handled, resulting in non-obvious behavior. |
Just to note, this is one case when it doesn't matter what is rendered - if they're the same, you can't tell the difference |
Sure, it was just re-wording of the Wiki statement - and that was written what should mapper do (not renderer), I just wanted to make it crystal clear what was the intention. Back to the subject: what do you think now about brand>name rendering priority? |
I think this was answered with #698 (comment) #698 (comment) when the issue was closed. I can't speak for @math1985, but I didn't expect everyone to agree, and I don't feel that anything new has been presented since then. |
sent from a phone
yes, rarely everyone agrees, but in this particular case nobody seemed to agree with your comment or the decision to close the issue. |
That is untrue, see #698 (comment) |
I'm not sure why this issue was closed. @pnorman
It seems to me that you're suggesting conflating name=* and brand=* tagging which at times may be the same, but in many situations is not. I agree with @matkoniecz that the "current state encourages misuse of name tag". What a mapper may "reasonably expect" is that rendering match adopted standards in practice and in the wiki. |
Note that #972 is still open. |
@pnorman I think we should not oversimplify things if they're not that simple in reality. Current state encourages tagging for renderer, which would be very unfortunate consequence and I'd like to avoid it. I have a helper question then: do you think we should never-ever drop name label priority over brand or could you consider some conditions which would justify such a change? Could it be making brand much more prominent than name as with fuel station preset in JOSM (or something like this)? |
sent from a phone
for gas stations I would always prefer brand over name for labeling a map, the name is something I d only want to see in search results or similar... |
@pnorman I think we still have a problem and I suggested a helper question to look further. Could you respond what do you think about "conditional" rendering brand? I guess editors showing brand field on top of the name (or even with no name field) is a strong case against calling it "non-obvious behavior" - it is obvious to tag the brand then. Or maybe there are some other conditions for you to feel satisfied? Or just you feel using brand field is a broken tagging at all? The details are important - knowing what is acceptable at least and what is out of any question in such a hard problem is crucial. |
I am seeing a lot of people here in Brazil wrongly including the One quick example: http://overpass-turbo.eu/s/bwO (click on Run) |
@pnorman Could you reply to my helper questions? I guess the problem won't go away anytime soon (see also new comments to the still open #1548), so I'd still like to find a compromise solution. |
...and we have brand new issue too. I really think it was too soon to close this issue, before we have tried to find the consensus (at least stating the limits of possible agreement). |
In my opinion |
Hello, I would suggest that the brand was informed first and then the company name . I understand that the user can more easily identify the gas station , bank or supermarket with the presentation in this order: brand name . |
Does anyone understands what is the disagreement about the the precise choice about whether or not displaying brand if name isn't present?
Is it the key point? (Correct as in complete I suppose) |
First of all this issue is about the specific suggestion to render a brand label on features without a name tag in a way that is not limited to specific feature classes. We have another issue on a more specific suggestion (#1874) that is open and we also had a pull request previously (#972) which was closed not because it was rejected but because it was stale. The question of the role of brands in identifying and characterizing commercial establishments of various kinds is highly multi-faceted, especially if you look at it from a international, multi-cultural perspective. There are concerns that when rendering (name OR brand) (or Beyond that and what has been discussed so far displaying brands can have a culture-imperialist subtext, especially in parts of the world that use a non-latin script since for economic reasons most brands are written in latin script which would then be a foreign object in the map appearance. In some parts of the world this integrates naturally into the local use of language and script while in other parts of the world the brand identity is perceived purely graphically based on logos and the latin script brand name is a truly alien artefact in the local cultural context. |
I admit that in this case I am unsure what would this rule or adding name name keys would be preferable, but I am unsure that at least one of these two should be done.
brand tag is in database, so it could be done before 3.0
example: http://www.openstreetmap.org/node/1111319733
migrated from trac https://trac.openstreetmap.org/ticket/3471
The text was updated successfully, but these errors were encountered: