Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render building=greenhouse differently #738

Open
matthijsmelissen opened this issue Jul 19, 2014 · 27 comments
Open

Render building=greenhouse differently #738

matthijsmelissen opened this issue Jul 19, 2014 · 27 comments
Assignees
Labels
buildings new features Requests to render new features

Comments

@matthijsmelissen
Copy link
Collaborator

Most buildings are about the same, but greenhouses look completely different, both, from on the ground and from aerial pictures.

But when you're on a place where there are a lot of greenhouses on the ground, the map looks just the same as when you're in a factory.

Currently, there are over 15.000 objects tagged with "building=greenhouse".

So I would propose a different rendering for that. I suggest a very pale version of the current building colour would do. Something like #EBDDDB (even paler than houses)

See also https://trac.openstreetmap.org/ticket/4654

@matthijsmelissen
Copy link
Collaborator Author

Let's wait with this until #565 has been accepted.

@matkoniecz
Copy link
Contributor

I would be against yet another rendering type for houses.

@dieterdreist
Copy link

2014-09-29 14:41 GMT+02:00 Mateusz Konieczny notifications@github.com:

I would be against yet another rendering type for houses.

this is not about houses but about greenhouses.

@matkoniecz
Copy link
Contributor

this is not about houses but about greenhouses.

Sorry, I should phrase it as "I would be against yet another rendering type for building=* elements"

@dieterdreist
Copy link

2014-09-29 14:51 GMT+02:00 Mateusz Konieczny notifications@github.com:

Sorry, I should phrase it as "I would be against yet another rendering
type for building=* elements"

I think that these structures do merit a different rendering, because they
are indeed not "buildings" in literal terms, but light structures. I see a
derise to be able to distinguish them from actual buildings to improve the
readability of the map.

@ffes
Copy link

ffes commented Sep 29, 2014

http://osm.org/go/0En~7hKU- is a good example of a lot of greenhouses in a relative small area.

@matthijsmelissen
Copy link
Collaborator Author

I would be against yet another rendering type for houses.

Does this area change your opinion? See also this aerial photo.

Edit: what @ffes says.

@matkoniecz
Copy link
Contributor

A better image of this location: http://www.alamy.com/stock-photo-CYFBFN/The-Netherlands-Monster-View-on-village-and-glass-houses-Aerial.html

This example is impressive. Now I have no clear opinion on this topic.

@dieterdreist
Copy link

Il giorno 29/set/2014, alle ore 15:19, Mateusz Konieczny notifications@github.com ha scritto:

This example is impressive.

there are similar areas in Spain around Almeria=

@mboeringa
Copy link

How I currently render it. Scale is unfortunately not exactly the same, but close. I think there is room for some dedicated renderings in the building class. Left Standard, right ArcGIS Renderer for OpenStreetMap. Click to enlarge:

arcgis_renderer_for_openstreetmap_greenhouses

@dieterdreist
Copy link

sent from a phone

Am 15.06.2015 um 22:52 schrieb mboeringa notifications@github.com:

I think there is room for some dedicated renderings in the building class.

I support this. Greenhouses are too dominant currently.

@kocio-pl
Copy link
Collaborator

So how do you think they should look like?

@ffes
Copy link

ffes commented Dec 15, 2016

There are two options.

The red used on the example above looks good to me. That would be my preference.

Otherwise a type of green. These things aren't called greenhouses for nothing.

@kocio-pl
Copy link
Collaborator

We use green for different natural/leisure purposes.

I don't see red - it's violet for me and we use it for industrial landuse.

I missed Something like #EBDDDB (even paler than houses). This sounds reasonable for me. In fact it looks like a subset of #1207, which is currently closed, but there was no strong opinion against it, so I would go this way for all minor buildings.

@kocio-pl kocio-pl self-assigned this Dec 15, 2016
@HolgerJeromin
Copy link
Contributor

What about an greenish gray as a mixture of nature and building?

@kocio-pl
Copy link
Collaborator

I like the idea of having just minor, normal and major building colors (and roofs, but it's not planned to have a separate color), and not being too specific.

I'm not sure how would this look like, but I would probably test it too, out of curiosity.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 2, 2017

#EBDDDB doesn't work - it looks like retail area for me:

9ytbn5kl

However lightening standard building color a bit looks OK:

qjfuviap

I've made a branch to easily add more minor buildings - like garages or roofs maybe.

@polarbearing
Copy link
Contributor

lightening standard building color ... add more minor buildings - like garages or roofs

works for me, and I like the idea of light buildings in general, it will encourage more people to be more specific than building=yes.

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 2, 2017

The area from this comment on z13:

Before
rt9t0pnk

After
mgy_dded

@kocio-pl
Copy link
Collaborator

I have no idea how to solve this in the other way than the one that was rejected, so I'm closing it now. The issue can be reopened when somebody will come with another idea.

@jeisenbe
Copy link
Collaborator

Update: buildings are no longer rendered at z13, so the key zoom level for the problem area in the comment is now z14.

We could still consider rendering greenhouses with transparence, because they are literally transparent. This wouldn't normally be a good idea with any other building type.

@kocio-pl
Copy link
Collaborator

Why render them in a special way instead of treating them like all the minor buildings (no matter how should they be rendered)?

@polarbearing
Copy link
Contributor

I'd be against transparency as in the end it is just a method of mixing colours, and there is nothing particular that would need to be seen "through" the transparency.

@mboeringa
Copy link

I have no idea how to solve this in the other way than the one that was rejected, so I'm closing it now. The issue can be reopened when somebody will come with another idea.

@kocio-pl
I actually think the arguments to close your proposal with lightening the buildings were weak, and @matthijsmelissen just said "I don't think the proposed solution is the best solution for the given problem." without giving real arguments to close it.

As I argued in the other thread, there are more distinguishing features of greenhouses that make them stand out from other (minor) buildings: generally big, rectangular, outside residential areas, usually densely packed.

Hence I still think that simply rendering them a bit lighter as you proposed and treat them like other minor buildings, is a perfectly valid choice. I would re-open it if I were you.

@kocio-pl
Copy link
Collaborator

Thanks. I don't feel the need, since there is current separate general discussion about minor buildings rendering (#3679) and this case is not forgotten.

@imagico
Copy link
Collaborator

imagico commented Feb 9, 2020

Reopening because this was closed neither as wontfix/declined nor duplicate nor as solved.

@imagico
Copy link
Collaborator

imagico commented Feb 9, 2020

Note the ac-style implements a differentiated rendering of building=greenhouse at the highest zoom levels: 7e99531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buildings new features Requests to render new features
Projects
None yet
Development

No branches or pull requests

10 participants