Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shop=no shouldn't get rendered #985

Closed
23cpo opened this issue Sep 26, 2014 · 9 comments · Fixed by #1349
Closed

shop=no shouldn't get rendered #985

23cpo opened this issue Sep 26, 2014 · 9 comments · Fixed by #1349
Labels
amenity-points
Milestone
Bugs and improvem...

Comments

@23cpo
Copy link

23cpo commented Sep 26, 2014

shop=no shouldn't get rendered: http://www.openstreetmap.org/node/1031607377
@dieterdreist
Copy link

2014-09-26 5:36 GMT+02:00 23cpo notifications@github.com:

shop=no shouldn't get rendered:
http://www.openstreetmap.org/node/1031607377

shouldn't even get mapped ;-)

@matthijsmelissen
Copy link
Collaborator

I think it's the combination of amenity=fuel and shop=no that causes this.

@23cpo
Copy link
Author

23cpo commented Sep 26, 2014

@dieterdreist maybe you're right, but it's 2304 times in the database ;)

@mboeringa
Copy link

I think it's the combination of amenity=fuel and shop=no that causes this.

Yes, and I think the OP actually wanted to say (maybe the title needs updating?):

"amenity=fuel is not rendered if a shop=x tag is present"

and I think this relates directly to #963. Maybe one of these issues needs closing.

@matkoniecz
Copy link
Contributor

Is it happening with shop=no on node without amenity=fuel?

@sb12
Copy link
Contributor

sb12 commented Sep 28, 2014

Is it happening with shop=no on node without amenity=fuel?

It happens in combination with amenity=* and highway=*. Does not happen when it has just a name.

Overpass-Turbo query to find more: http://overpass-turbo.eu/s/5de

shouldn't even get mapped ;-)

I think it's the combination of amenity=fuel and shop=no that causes this.

It's in the JOSM preset for fuel stations.

@HolgerJeromin
Copy link
Contributor

Combined with fuel tagging it no seems to be a value in the data. In Germany most have a shop.

@dieterdreist
Copy link

2014-09-28 22:58 GMT+02:00 Holger Jeromin notifications@github.com:

Combined with fuel tagging it no seems to be a value in the data. In
Germany most have a shop.

agree, while in Italy most don't have a shop. I would suggest to tag the
shop in the ones that do have a shop anyway (but tagging shop=no has some
reason to be in the described context).

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Oct 10, 2014
@matthijsmelissen
Rewrite SQL queries so the COALESCE part works correctly
5dd84e9 
* Resolves gravitystorm#985
* Resolves gravitystorm#1029
@matthijsmelissen matthijsmelissen mentioned this issue Oct 10, 2014
Closed
@matthijsmelissen
Copy link
Collaborator

This has the same root cause as #963.

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 4, 2015
@matthijsmelissen
Resolve bugs related to COALESCE problems
aa53e41 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
@matthijsmelissen matthijsmelissen mentioned this issue Mar 4, 2015
Merged
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 4, 2015
@matthijsmelissen
Resolve bugs related to COALESCE problems
4a3dfaf 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 4, 2015
@matthijsmelissen
Resolve bugs related to COALESCE problems
4933cdb 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 9, 2015
@matthijsmelissen
Resolve bugs related to COALESCE problems
f93b782 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
sommerluk pushed a commit to sommerluk/openstreetmap-carto that referenced this issue Mar 16, 2015
@matthijsmelissen @sommerluk
Resolve bugs related to COALESCE problems
fa1128f 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
amenity-points
Projects
None yet
Milestone
Bugs and improvements
7 participants
@dieterdreist @matkoniecz @HolgerJeromin @matthijsmelissen @23cpo @sb12 @mboeringa